Trim whitespace when parsing table metadata. #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkuchida
reviewed
Jun 11, 2020
| std::remove(emptyFileName.c_str()); | ||
| } |
There was a problem hiding this comment.
Should there be a try/catch block here so the file gets deleted even if the SimTK_TEST_MUST_THROW_EXC() fails?
There was a problem hiding this comment.
I added a FileRemover class to handle this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of opensim-org/opensim-moco#616
Brief summary of changes
DelimFileAdapter.testSTOFileAdapternow uses the Catch testing framework.testSTOFileAdapteris now more lenient: whitespace is trimmed before checking if headers are equivalent.Testing I've completed
Updated and ran
testSTOFileAdapter.CHANGELOG.md (choose one)
The Doxygen for this PR can be viewed at http://myosin.sourceforge.net/?C=N;O=D; click the folder whose name is this PR's number.
This change is