Skip to content

Commit

Permalink
Merge pull request #4001 from opensim-org/fix_path_fitter_num_coordin…
Browse files Browse the repository at this point in the history
…ates

Allow paths fit by `PolynomialPathFitter` to depend on more than 6 coordinates
  • Loading branch information
nickbianco authored Jan 31, 2025
2 parents 1281035 + 3c00c00 commit c46cc98
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ v4.6
decorations were emitted for both `true` and `false`, resulting in double-emission).
- It will now check for NaNed vectors coming from the underlying expression, skipping emission
if one is detected (previously: it would emit decorations with `NaN`ed transforms).
- `PolynomialPathFitter` now allows fitting paths that depend on more than 6 coordinates, matching recent changes to `MultivariatePolynomialFunction` (#4001).

v4.5.1
======
Expand Down
4 changes: 0 additions & 4 deletions OpenSim/Actuators/PolynomialPathFitter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -842,10 +842,6 @@ void PolynomialPathFitter::filterSampledData(const Model& model,
momentArms.removeColumn(label);
} else {
momentArmMap[path].push_back(coordinate);
OPENSIM_THROW_IF_FRMOBJ(momentArmMap[path].size() > 6,
Exception,
"The path '{}' depends on more than 6 coordinates. "
"This is not supported.", path)
}
}
}
Expand Down

0 comments on commit c46cc98

Please sign in to comment.