Fix #8168 - AWS secrets should not be exposed while running tests #342
+332
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Jiang <[email protected]>
Signed-off-by: Lyndon-Li <[email protected]>
Add resource modifier for velero restore describe CLI
… Descriptive restore error on terminating namespace. (vmware-tanzu#7424) revert utils_test.go address https://github.com/vmware-tanzu/velero/pull/7424/files/c7b189dd6035839c9eb8ce3dab4ead574de77adb#r1494194484 Update pkg/util/kube/utils.go Signed-off-by: Tiger Kaovilai <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Daniel Jiang <[email protected]>
Issues with "backlog" label should never stale
Signed-off-by: Lyndon-Li <[email protected]>
…-resource-limit node-agent config for data mover micro service pod resources
Signed-off-by: Lyndon-Li <[email protected]>
Signed-off-by: Shubham Pampattiwar <[email protected]> add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> make backupPod volume mount always readOnly Signed-off-by: Shubham Pampattiwar <[email protected]> use assert.True() Signed-off-by: Shubham Pampattiwar <[email protected]> Add readOnly param for MakePodPVCAttachment func lint fix Signed-off-by: Shubham Pampattiwar <[email protected]>
…kup-pvc-config Apply backupPVCConfig to backupPod volume spec
…ng tests Changed the tests to use mocked function that will not read actual secrets from env variables nor AWS config file that may be on the system that is running tests. As a second guard against exposed secrets comparison for the values does not shows the actual values for the AWS data. This is to prevent situation where programming error may still allow the test to read AWS config/env variables instead of using mocked function. Signed-off-by: Michal Pryc <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Changed the tests to use mocked function that will not read actual secrets from env variables nor AWS config file that may be on the system that is running tests.
As a second guard against exposed secrets comparison for the values does not shows the actual values for the AWS data. This is to prevent situation where programming error may still allow the test to read AWS config/env variables instead of using mocked function.
This change also fixes the test run on the system with AWS creds where the test was failing.
Does your change fix a particular issue?
Fixes vmware-tanzu#8168
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.