Skip to content

OCPEDGE-1519: feat: add tnf abi presubmit to installer #69565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

OCPEDGE-1519: feat: add tnf abi presubmit to installer #69565

merged 1 commit into from
Oct 21, 2025

Conversation

@eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Sep 22, 2025

add presubmit lane for tnf agent changes to the installer repo

@eggfoobar eggfoobar force-pushed the add-tnf-installer-presubmit branch 2 times, most recently from b12fe05 to 60a758d Compare September 22, 2025 19:30
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Sep 22, 2025

pj-rehease TNF_IPV4 variable validation will be done once has been merged in to openshift-metal3/dev-scripts#1798

@eggfoobar eggfoobar mentioned this pull request Sep 22, 2025
Open
@eggfoobar eggfoobar force-pushed the add-tnf-installer-presubmit branch from 60a758d to 1ec713f Compare September 23, 2025 14:09
@andfasano
Copy link
Contributor

andfasano commented Sep 23, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2025
@eggfoobar eggfoobar changed the title feat: add tnf abi presubmit to installer OCPEDGE-1519: feat: add tnf abi presubmit to installer Sep 24, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 24, 2025 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

add presubmit lane for tnf agent changes to the installer repo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar eggfoobar force-pushed the add-tnf-installer-presubmit branch from 1ec713f to df4cb68 Compare October 14, 2025 02:26
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Oct 17, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2025

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jaypoulz
Copy link
Contributor

jaypoulz commented Oct 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2025
@eggfoobar eggfoobar force-pushed the add-tnf-installer-presubmit branch from df4cb68 to 08ed63f Compare October 20, 2025 18:29
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Oct 20, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 20, 2025

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jaypoulz
Copy link
Contributor

jaypoulz commented Oct 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Oct 20, 2025

/retest

@eggfoobar
feat: add tnf abi presubmit to installer
e4fd5d0 
added two node fencing agent ipv4 workflow
added presubmit lane for tnf agent changes to the installer repo

Signed-off-by: ehila <[email protected]>
@eggfoobar eggfoobar force-pushed the add-tnf-installer-presubmit branch from 08ed63f to e4fd5d0 Compare October 21, 2025 01:57
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Oct 21, 2025

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2025

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2025

[REHEARSALNOTIFIER]
@eggfoobar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.21-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-release-4.22-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Oct 21, 2025

/pj-rehearse ack

We expected failures, this jobs will allow us to validate ABI support in the installer.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2025

@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 21, 2025
@fonta-rh
Copy link

fonta-rh commented Oct 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, eggfoobar, fonta-rh, jaypoulz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/release-4.21/e2e-agent-two-node-fencing-ipv4 e4fd5d0 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.21-e2e-agent-two-node-fencing-ipv4
ci/rehearse/openshift/installer/main/e2e-agent-two-node-fencing-ipv4 e4fd5d0 link unknown /pj-rehearse pull-ci-openshift-installer-main-e2e-agent-two-node-fencing-ipv4
ci/rehearse/openshift/installer/release-4.22/e2e-agent-two-node-fencing-ipv4 e4fd5d0 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.22-e2e-agent-two-node-fencing-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 977aa2a into openshift:master Oct 21, 2025
17 of 20 checks passed
sgoveas pushed a commit to sgoveas/release that referenced this pull request Oct 21, 2025
@eggfoobar @sgoveas
feat: add tnf abi presubmit to installer (openshift#69565)
8b4d661 
added two node fencing agent ipv4 workflow
added presubmit lane for tnf agent changes to the installer repo

Signed-off-by: ehila <[email protected]>
@eggfoobar eggfoobar deleted the add-tnf-installer-presubmit branch October 21, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

1 more reviewer

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jaypoulz jaypoulz

@fonta-rh fonta-rh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eggfoobar @andfasano @openshift-ci-robot @jaypoulz @fonta-rh