This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 514
rhc-list-ports: Delete scaled gears output code #6049
Open
Miciah
wants to merge
1
commit into
openshift:master
Choose a base branch
from
Miciah:rhc-list-ports-delete-output-of-scaled-gears
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
rhc-list-ports: Delete scaled gears output code #6049
Miciah
wants to merge
1
commit into
openshift:master
from
Miciah:rhc-list-ports-delete-output-of-scaled-gears
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete the code that prints the list of scaled gears because it has been broken for a over a year and has no users. Commit 487e6e2 broke the code in question by replacing haproxy/conf/gear-registry.db with gear-registry/gear-registry.json.
[test] [extended:node,rhc,gear] |
[test] [extended:node,rhc,gear] |
[test] |
We're seeing the following error four times:
and the following error four times as well:
neither of which looks related to the changes in this PR. [test] again. |
[test] again in hopes that https://www.github.com/openshift/origin-server/pull/6219 fixed the failing tests. |
Blocked by failures in the gear extended tests, which will be fixed by #6291. |
[test] again please! |
Maybe the test failures got fixed? [test] again please! |
Evaluated for online test up to d6bcf2d |
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/9343/) (Extended Tests: node, rhc, gear) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the code that prints the list of scaled gears because it has been broken for a over a year and has no users.
Commit 487e6e2 broke the code in question by replacing
haproxy/conf/gear-registry.db
withgear-registry/gear-registry.json
.This pull request supersedes PR #5988.