Skip to content

OSDOCS 15252 MachineOSConfig name should match MachineConfigPool #96902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Jul 30, 2025

https://issues.redhat.com/browse/OSDOCS-15604

Might need to manually CP to 4.18. Made structural changes to the modules for the 4.19 GA release.

Don't merge until openshift/api#2399 is merged

Link to docs preview:
Using the on-cluster image mode to apply a custom layered image -- New second paragraph (after bullets); updated step 1a, callout 2.
Modifying an on-cluster custom layered image -- Updated namespace in example under step 1a.

QE review:

  • QE has approved this change.

@mburke5678 mburke5678 added this to the Continuous Release milestone Jul 30, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 30, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 30, 2025

🤖 Thu Aug 07 22:45:31 - Prow CI generated the docs preview:

https://96902--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/mco-coreos-layering.html

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2025
@mburke5678
Copy link
Contributor Author

@umohnani8 PTAL

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2025
@mburke5678
Copy link
Contributor Author

@ptalgulk01 Can you PTAL?

@ptalgulk01
Copy link

content looks good

@mburke5678 mburke5678 added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 7, 2025
@mburke5678 mburke5678 changed the title OSDOCS15252 MachineOSConfig name should match MachineConfigPool OSDOCS 15252 MachineOSConfig name should match MachineConfigPool Aug 7, 2025
Copy link

openshift-ci bot commented Aug 7, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 8, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Skipping the merge as per the comment 0. Thanks!

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 8, 2025
@umohnani8
Copy link

@mburke5678 openshift/api#2399 has merged so this is good to go now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants