-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS 15252 MachineOSConfig name should match MachineConfigPool #96902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Thu Aug 07 22:45:31 - Prow CI generated the docs preview: |
d0d145a
to
8066cd7
Compare
@umohnani8 PTAL |
@ptalgulk01 Can you PTAL? |
content looks good |
5e3eab8
to
4b9fee6
Compare
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Skipping the merge as per the comment 0. Thanks!
@mburke5678 openshift/api#2399 has merged so this is good to go now |
https://issues.redhat.com/browse/OSDOCS-15604
Might need to manually CP to 4.18. Made structural changes to the modules for the 4.19 GA release.
Don't merge until openshift/api#2399 is merged
Link to docs preview:
Using the on-cluster image mode to apply a custom layered image -- New second paragraph (after bullets); updated step 1a, callout 2.
Modifying an on-cluster custom layered image -- Updated namespace in example under step 1a.
QE review: