Skip to content

CNF#18626: Change bm-sno communication matrix name to none-sno #95468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: enterprise-4.18
Choose a base branch
from

Conversation

shirmoran
Copy link

@shirmoran shirmoran commented Jul 1, 2025

As the bm-sno cluster telco partners deploys is of platform type "None", we want to change the name of the files containing this type of commatrix data to none, to avoid confusion. Hence we have duplicated the bm-sno commatrix under the name none-sno (see PR). after changing the pointer to the new communication matrix, the old one will be deleted.

Version(s):

4.18

Issue:

https://issues.redhat.com/browse/CNF-18626

Link to docs preview:
OpenShift Container Platform network flow matrix -- Second bullet
Additional network flows for single-node OpenShift on bare metal -- Table

QE review:

  • QE has approved this change.

Additional information:

As the bm-sno cluster telco partners deploys is of platform type "None", we want to change the name of the files containing this type of commatrix data to none, to avoid confusion.
Hence we have duplicated the bm-sno commatrix under the name none-sno
(see PR openshift-kni/commatrix#149). after
changing the pointer to the new communication matrix, the old one will
be deleted.
@shirmoran shirmoran changed the title Change bm-sno communication matrix name to none-sno CNF#18626: Change bm-sno communication matrix name to none-sno Jul 1, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2025
@ocpdocs-previewbot
Copy link

🤖 Tue Jul 01 08:29:38 - Prow CI generated the docs preview:

https://95468--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/install_config/configuring-firewall.html

Copy link

openshift-ci bot commented Jul 1, 2025

@shirmoran: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shirmoran
Copy link
Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 1, 2025
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 1, 2025
@mburke5678
Copy link
Contributor

/lgtm
This change is for 4.18 only. The affected items were added in 4.18 and removed in 4.19.
I am assuming that CSV files can be included in this manner, as it was approved before.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 1, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
@aabughosh
Copy link

/approve
/lgtm

@shirmoran
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 3, 2025
@maxwelldb maxwelldb added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Jul 3, 2025
@maxwelldb maxwelldb added this to the Continuous Release milestone Jul 3, 2025
@maxwelldb maxwelldb self-requested a review July 3, 2025 14:03
@maxwelldb
Copy link
Contributor

@shirmoran lgtm. Could you just confirm if this has a QE ack? Box isn't checked and the Jira item wasn't yet removed into the review stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants