Skip to content

OCPBUGS-55260#Add static provisioning content for Azure File #94557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-55260#Add static provisioning content for Azure File #94557

wants to merge 1 commit into from
+118 −0

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Jun 10, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2025
@lpettyjo lpettyjo added this to the Continuous Release milestone Jun 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 10, 2025 •
edited
Loading

🤖 Fri Jun 27 18:26:35 - Prow CI generated the docs preview:

https://94557--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-azure-file.html

GroceryBoyJr
GroceryBoyJr reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a couple tiny nits.

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 10, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2025

@GroceryBoyJr: Those labels are not set on the issue: peer-review-in-progress

In response to this:

/label peer-review-done
/remove-label peer-review-in-progress
/unassign GroceryBoyJr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 10, 2025
@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

duanwei33
duanwei33 reviewed Jun 26, 2025
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 27, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@duanwei33
Copy link

The format for the new added secret part doesn't look good, not sure if it is okay in official doc.
Others LGTM.

@jsafrane
Copy link
Contributor

The factual content of the secret doc LGTM. I let others judge the format.

gcharot
gcharot reviewed Jun 30, 2025
View reviewed changes
modules/persistent-storage-csi-azure-file-static-provisioning-procedure.adoc
<2> Namespace for the PVC.
<3> The name of the PV that you created in the previous step.
<4> Storage class name. This name is used by the PVC to bind to this specific PV. For static provisioning, a `StorageClass` object does not need to exist, but the name in the PV and PVC must match.
<5> Access mode. Sets read and/or write access for the PVC.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

gcharot
gcharot reviewed Jun 30, 2025
View reviewed changes
modules/persistent-storage-csi-azure-file-static-provisioning-procedure.adoc
<11> File share name. Use only the file share name; do not use full path.
<12> This secret must contain the Azure Storage Account name and key.
+
The secret must have a very specific format with two key-value pairs:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move this at the top of the procedure and just do a reference here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@gcharot gcharot gcharot left review comments

@duanwei33 duanwei33 duanwei33 left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@lpettyjo @ocpdocs-previewbot @GroceryBoyJr @bergerhoffer @duanwei33 @jsafrane @gcharot @jeana-redhat @ocpdocs-vale-bot