-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#14805: adding API section #94101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@aravipra: This pull request references OSDOCS-14805 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Thu Jun 26 16:50:52 - Prow CI generated the docs preview: |
@aravipra: This pull request references OSDOCS-14805 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@aravipra: This pull request references OSDOCS-14805 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
455b4ee
to
28fafae
Compare
modules/eso-bitwarden-secret.adoc
Outdated
| `enabled` | ||
| `enabled` is for enabling the bitwarden secrets manager provider, which can be indicated by setting `true` or `false`. | ||
| false | ||
| Enum: [true false] Optional: \{\} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'data enumeration' rather than 'Enum'. For more information, see RedHat.TermsErrors.
modules/eso-cert-manager-config.adoc
Outdated
| `enabled` | ||
| `enabled` is for enabling the use of cert-manager for obtaining and renewing the certificates used for webhook server, instead of built-in certificates. Use `true` or `false` to indicate the preference. | ||
| false | ||
| Enum: [true false] Optional: \{\} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'data enumeration' rather than 'Enum'. For more information, see RedHat.TermsErrors.
modules/eso-cert-manager-config.adoc
Outdated
| `addInjectorAnnotations` | ||
| `addInjectorAnnotations` is for adding the `cert-manager.io/inject-ca-from` annotation to the webhooks and CRDs to automatically setup webhook to the cert-manager CA. This requires CA Injector to be enabled in cert-manager. Use `true` or `false` to indicate the preference. | ||
| false | ||
| Enum: [true false] Optional: \{\} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'data enumeration' rather than 'Enum'. For more information, see RedHat.TermsErrors.
66098c0
to
b800c68
Compare
| _string_ | ||
| `addInjectorAnnotations` adds the `cert-manager.io/inject-ca-from` annotation to the webhooks and custom resource definitions (CRDs) to automatically configure the webhook with the `cert-manager` Operator certificate authority (CA). This requires CA Injector to be enabled in `cert-manager` Operator. Set this field to `true` or `false`. | ||
| false | ||
| enum: [true false] + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'data enumeration' rather than 'enum'. For more information, see RedHat.TermsErrors.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/label qe-approved
@aravipra: This pull request references OSDOCS-14805 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@aravipra: This pull request references OSDOCS-14805 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
New changes are detected. LGTM label has been removed. |
@aravipra: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| _string_ | ||
| `enabled` field enables the `bitwardenSecretManagerProvider`. you can set this field to `true` or `false`. | ||
| false | ||
| enum: [true false] + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'data enumeration' rather than 'enum'. For more information, see RedHat.TermsErrors.
| _string_ | ||
| `enabled` specifies whether cert-manager must obtain and renew certificates for the webhook server instead of using built-in certificates. Set this field to `true` or `false`. | ||
| false | ||
| enum: [true false] + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'data enumeration' rather than 'enum'. For more information, see RedHat.TermsErrors.
| _string_ | ||
| `addInjectorAnnotations` adds the `cert-manager.io/inject-ca-from` annotation to the webhooks and custom resource definitions (CRDs) to automatically configure the webhook with the `cert-manager` Operator certificate authority (CA). This requires CA Injector to be enabled in `cert-manager` Operator. Set this field to `true` or `false`. | ||
| false | ||
| enum: [true false] + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'data enumeration' rather than 'enum'. For more information, see RedHat.TermsErrors.
@aravipra: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.20 |
@snarayan-redhat: new pull request created: #95308 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@snarayan-redhat: new pull request created: #95309 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.19+
Issue:
OSDOCS-14805
Link to docs preview:
External Secrets Operator for Red Hat OpenShift APIs
QE review:
SME review: