Skip to content

[RHACS] [Docs] ROX-29351: Adding documentation for keyless verification #94078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: rhacs-docs-main
Choose a base branch
from
Open

[RHACS] [Docs] ROX-29351: Adding documentation for keyless verification #94078

wants to merge 2 commits into from

Conversation

agantony
Copy link
Contributor

@agantony agantony commented Jun 2, 2025 •
edited
Loading

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/ROX-29351

Link to docs preview:
https://94078--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/verify-image-signatures#securing-container-images-by-using-signature-integration_verify-image-signatures

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherrypick to:
    • rhacs-docs-4.8

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-29351 which is a valid jira issue.

In response to this:

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/ROX-29351

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherrypick to:
    • rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony added peer-review-needed Signifies that the peer review team needs to review this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 labels Jun 2, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 2, 2025 •
edited
Loading

🤖 Thu Jun 05 08:45:32 - Prow CI generated the docs preview:
https://94078--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@ShaunaDiaz ShaunaDiaz added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-29351 which is a valid jira issue.

In response to this:

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/ROX-29351

Link to docs preview:
https://94078--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/verify-image-signatures#performing-an-image-signature-verification_verify-image-signatures

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherrypick to:
    • rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ShaunaDiaz
ShaunaDiaz reviewed Jun 2, 2025
View reviewed changes
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agantony the content here looks fine overall, but it is not properly organized and does not follow mod-docs guidelines, so I think the meaning has been lost. Highly recommend you modularize the Optional procedures and zoom the focus in on job to be done.

@ShaunaDiaz ShaunaDiaz added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-29351 which is a valid jira issue.

In response to this:

Version(s):
4.8+

Issue:
https://issues.redhat.com/browse/ROX-29351

Link to docs preview:
https://94078--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/verify-image-signatures#securing-container-images-by-using-signature-integration_verify-image-signatures

SME review:

  • SME has approved this change.

Additional information:

  • Merge into rhacs-docs-main and cherrypick to:
    • rhacs-docs-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony
Copy link
Contributor Author

agantony commented Jun 2, 2025

Creating a signature integration and scanning an image signature are two separate tasks, so I have created 2 separate modules for these tasks.

@agantony agantony force-pushed the ROX29351-rhacs-docs-main branch from b5bc467 to 3a35758 Compare June 2, 2025 19:10
@agantony agantony requested a review from stehessel June 2, 2025 19:11
stehessel
stehessel reviewed Jun 4, 2025
View reviewed changes
@agantony agantony requested a review from stehessel June 4, 2025 11:36
@agantony agantony force-pushed the ROX29351-rhacs-docs-main branch from 3a35758 to 96e5a79 Compare June 4, 2025 11:36
ROX29351 Adding documentation for keyless verification
cb90efa 
ROX29351 Review comments

ROX29351 Review comments

ROX29351 Review comments

ROX29351 Review comments
@agantony agantony force-pushed the ROX29351-rhacs-docs-main branch from 96e5a79 to cb90efa Compare June 5, 2025 05:45
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 5, 2025

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

@stehessel stehessel Awaiting requested review from stehessel

Assignees

@stehessel stehessel

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.8 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agantony @openshift-ci-robot @ocpdocs-previewbot @stehessel @ShaunaDiaz