Skip to content

[release-4.19] OCPBUGS-66920: Add ValidatingAdmissionPolicy and check for omissions next time. #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-4.19] OCPBUGS-66920: Add ValidatingAdmissionPolicy and check for omissions next time. #586

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 5, 2025

This is an automated cherry-pick of #577

/assign openshift-cherrypick-robot

/cherrypick release-4.18

@benluddy
Add ValidatingAdmissionPolicy and check for omissions next time.
4b7ef14 
The default admission plugin list requires manual synchronization every time upstream introduces a
new default plugin. To make future dependency bumps less error-prone, it should now fail if
upstream's default list names a plugin that is not either included in the downstream list or in a
list of intentionally-omitted plugins. Likewise, it should also fail if the downstream list contains
a plugin that is not either included in the upstream list or in a list of intentionally-added
plugins.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 5, 2025
Merged
@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from dgrisonnet and tkashem December 5, 2025 19:44
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-65848 has been cloned as Jira Issue OCPBUGS-66920. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-66920: Add ValidatingAdmissionPolicy and check for omissions next time.

Details

In response to this:

This is an automated cherry-pick of #577

/assign openshift-cherrypick-robot

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-65848: Add ValidatingAdmissionPolicy and check for omissions next time. [release-4.19] OCPBUGS-66920: Add ValidatingAdmissionPolicy and check for omissions next time. Dec 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-66920, which is invalid:

  • expected dependent Jira Issue OCPBUGS-65848 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #577

/assign openshift-cherrypick-robot

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy
Copy link
Contributor

benluddy commented Dec 17, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2025

@benluddy: This pull request references Jira Issue OCPBUGS-66920, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-65848 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-65848 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gangwgr December 17, 2025 16:47
@benluddy
Copy link
Contributor

benluddy commented Dec 17, 2025

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Dec 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025
@gangwgr
Copy link
Contributor

gangwgr commented Dec 18, 2025

/retest-required

1 similar comment
@gangwgr
Copy link
Contributor

gangwgr commented Dec 18, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-1of2 4b7ef14 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-serial-2of2 4b7ef14 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-ovn 4b7ef14 link true /test e2e-aws-ovn
ci/prow/unit 4b7ef14 link true /test unit
ci/prow/e2e-aws-ovn-upgrade 4b7ef14 link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@benluddy
Copy link
Contributor

benluddy commented Dec 18, 2025

/close

In favor of #588.

@openshift-ci openshift-ci bot closed this Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@benluddy: Closed this PR.

Details

In response to this:

/close

In favor of #588.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2025

@openshift-cherrypick-robot: An error was encountered searching for bug OCPBUGS-66920 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. You do not have the permission to see the specified issue.: request failed. Please analyze the request body for more details. Status code: 401:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

This is an automated cherry-pick of #577

/assign openshift-cherrypick-robot

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@tkashem tkashem Awaiting requested review from tkashem

@gangwgr gangwgr Awaiting requested review from gangwgr

Assignees

@benluddy benluddy

@xingxingxia xingxingxia

@openshift-cherrypick-robot openshift-cherrypick-robot

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @benluddy @gangwgr @xingxingxia @wangke19