Skip to content

OCPNETUI-140: Align shared modules with Console - #546

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
rszwajko:sharedModulesUtils
Sep 28, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
rszwajko:sharedModulesUtils

Conversation

@rszwajko

@rszwajko rszwajko commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Add utils to verify and sync shared modules:

  1. check all PatternFly dependencies due to known issues
  2. there should be only one resolution per each shared module and PatternFly package.

Reference-Url: https://redhat.atlassian.net/browse/OCPBUGS-127046
Reference-Url: kubevirt-ui/kubevirt-plugin#4420
Reference-Url: openshift/console#17259
Assisted-by: Cursor:claude-opus-4.6

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 25, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 25, 2026 •

Copy link
Copy Markdown

@rszwajko: This pull request references OCPNETUI-140 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

  1. check all PatternFly dependencies due to knwon issues
  2. there should be only one resolution per each shared module and PatternFly package.

Reference-Url: https://redhat.atlassian.net/browse/OCPBUGS-127046
Reference-Url: kubevirt-ui/kubevirt-plugin#4420
Assisted-by: Cursor:claude-opus-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2026
@openshift-ci

openshift-ci Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6e90584b-e5f4-459b-bcae-d0e545f5e51c


Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2026
@rszwajko

Copy link
Copy Markdown
Contributor Author

Blocked on shared modules resolution:

=== Shared modules ===

✅ @openshift-console/dynamic-plugin-sdk (4.23.0-prerelease.5)
✅ @openshift-console/dynamic-plugin-sdk-internal (4.23.0-prerelease.4)
✅ @openshift-console/dynamic-plugin-sdk-webpack (4.23.0-prerelease.5)
❌ @openshift/dynamic-plugin-sdk — 2 resolutions found:
     registry.npmjs.org/@openshift/dynamic-plugin-sdk/-/dynamic-plugin-sdk-8.2.0.tgz
     registry.npmjs.org/@openshift/dynamic-plugin-sdk/-/dynamic-plugin-sdk-9.1.0.tgz
✅ react (18.3.1)
✅ react-i18next (16.5.8)
✅ react-router (7.18.1)

❌ 1 check(s) failed. Each shared module must have a single resolution.

@rszwajko rszwajko changed the title OCPNETUI-140: Add utils to verify and sync shared modules with Console OCPNETUI-140: Align shared modules with Console Sep 28, 2026
@rszwajko rszwajko self-assigned this Sep 28, 2026
@rszwajko
rszwajko marked this pull request as ready for review September 28, 2026 12:31
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2026
@openshift-ci
openshift-ci Bot requested a review from galkremer1 September 28, 2026 12:32
@rszwajko
rszwajko marked this pull request as draft September 28, 2026 12:45
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2026
1. check all PatternFly dependencies due to known issues
2. there should be only one resolution per each shared module
    and PatternFly package.

Reference-Url: https://redhat.atlassian.net/browse/OCPBUGS-127046
Reference-Url: kubevirt-ui/kubevirt-plugin#4420
Assisted-by: Cursor:claude-opus-4.6
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Reference-Url: openshift/console#17259
Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@rszwajko
rszwajko marked this pull request as ready for review September 28, 2026 19:34
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2026
@openshift-ci
openshift-ci Bot requested a review from sjd78 September 28, 2026 19:35

@pcbailey pcbailey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2026
@openshift-ci

openshift-ci Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rszwajko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci

openshift-ci Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@rszwajko: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 783d49f into openshift:main Sep 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants