Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-2843: Remove cgroupv1 configurtion support from OCP #4822

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sairameshv
Copy link
Member

- What I did
Removed support to configure cgroupsv1 from nodes.config object

- How to verify it
Update the CgroupMode field of ndes.config object and verify that the system errors and doesn't update the nodes with the cgroupv1 based kernelArgs

- Description for the changelog

Cgroupsv1 support deprecation condition/message has been added in the last release and this PR removes the support to configure the same.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2025

@sairameshv: This pull request references OCPNODE-2843 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did
Removed support to configure cgroupsv1 from nodes.config object

- How to verify it
Update the CgroupMode field of ndes.config object and verify that the system errors and doesn't update the nodes with the cgroupv1 based kernelArgs

- Description for the changelog

Cgroupsv1 support deprecation condition/message has been added in the last release and this PR removes the support to configure the same.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 30, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2025
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sairameshv
Once this PR has been reviewed and has the lgtm label, please assign dkhater-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sairameshv
Copy link
Member Author

/jira refresh
/test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2025

@sairameshv: This pull request references OCPNODE-2843 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh
/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 30, 2025

@sairameshv: This pull request references OCPNODE-2843 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv
Copy link
Member Author

Related openshift/api PR: openshift/api#2181

Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@sairameshv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 0f9a11b link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade-out-of-change 0f9a11b link false /test e2e-aws-ovn-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn 0f9a11b link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change 0f9a11b link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-vsphere-ovn-upi-zones 0f9a11b link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-aws-ovn-upgrade 0f9a11b link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants