Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-48284: Do not run resolv-prepender from NM dispatcher #4783

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-48284: Do not run resolv-prepender from NM dispatcher #4783

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4654

/assign openshift-ci-robot

@mkowalski
OPNET-569: Do not run resolv-prepender from NM dispatcher
90ef05c 
This PR changes the logic of how NetworkManager communicates changes in
the environment and how they are picked by on-prem-resolv-prepender.

Previously the NM dispatcher script had a logic that would trigger a
systemd service (either to start it or to restart). This proven to be
problematic, prone to race conditions and in principle a complicated
design.

Now we are moving to a model where systemd on its own will decide what
and when to restart, in our case by leveraging the systemd path units.

NM dispatcher is now responsible only for writing a correct environment
file (we need that in case DNS search domains change). Systemd path unit
observes the file and if a change is detected, it will trigger whatever
is necessary.

There is other stuff in the NM dispatcher script that we are keeping as
it is out of scope of this refactor.

Closes: OPNET-569
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 10, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OPNET-569

In response to this:

This is an automated cherry-pick of #4654

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jcpowermac and mandre January 10, 2025 15:35
@mkowalski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski, openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign cdoern for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkowalski
Copy link
Contributor

/retitle [release-4.15] OCPBUGS-48284: Do not run resolv-prepender from NM dispatcher

@openshift-ci openshift-ci bot changed the title [release-4.15] OPNET-569: Do not run resolv-prepender from NM dispatcher [release-4.15] OCPBUGS-48284: Do not run resolv-prepender from NM dispatcher Jan 10, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48284, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48283 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #4654

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 90ef05c link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-gcp-op 90ef05c link false /test okd-scos-e2e-gcp-op
ci/prow/e2e-vsphere-ovn-upi-zones 90ef05c link false /test e2e-vsphere-ovn-upi-zones
ci/prow/okd-scos-e2e-aws-ovn 90ef05c link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mandre mandre Awaiting requested review from mandre

Assignees

@mkowalski mkowalski

@openshift-ci-robot openshift-ci-robot

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @mkowalski