Skip to content

Conversation

@aman4433
Copy link
Contributor

This Pull Request updates the base image for the machine-api-provider-powervs image to UBI 9 Minimal to align with the OpenShift 4.21 release requirements for reducing CVE count and image size.

cc/ @prb112

@Karthik-K-N
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 19, 2025
@prb112
Copy link

prb112 commented Nov 19, 2025

Looks fine, as @yussufsh brought up - we want https://github.com/openshift/machine-api-provider-powervs/blob/main/Dockerfile.rhel to be updated in a similar way.

Copy link
Member

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

for confirmation about changes and testing.

&& GOPROXY=off NO_DOCKER=1 make build

FROM registry.ci.openshift.org/ocp/4.21:base-rhel9
FROM registry.redhat.io/ubi9/ubi-minimal:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I not sure about this.
@damdo curious to know your thoughts, Are we supposed to update here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @Karthik-K-N This is in line with the instructions given at https://issues.redhat.com/browse/OCPSTRAT-2553

Teams will also need to ensure that all runtime dependencies, if any, are met if they were previously implicitly installed in the base image.

So you have to ensure that all the runtimes are installed and the project is working.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@aman4433: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

&& GOPROXY=off NO_DOCKER=1 GOARCH=ppc64le make build

FROM --platform=ppc64le registry.access.redhat.com/ubi8/ubi:8.4
FROM --platform=ppc64le registry.redhat.io/ubi9/ubi-minimal:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not be needed .But I feel good to keep same here for consistency.

Copy link

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aman4433, prb112
Once this PR has been reviewed and has the lgtm label, please assign aleskandro for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot changed the title Update base image to UBI 9 minimal [MULTIARCH-5801](https://issues.redhat.com//browse/MULTIARCH-5801): switch to ubi-minimal image for 4.21 Nov 19, 2025
@prb112
Copy link

prb112 commented Nov 19, 2025

/retitle MULTIARCH-5801: switch to ubi-minimal image for 4.21

@openshift-ci openshift-ci bot changed the title [MULTIARCH-5801](https://issues.redhat.com//browse/MULTIARCH-5801): switch to ubi-minimal image for 4.21 MULTIARCH-5801: switch to ubi-minimal image for 4.21 Nov 19, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2025

@aman4433: This pull request references MULTIARCH-5801 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This Pull Request updates the base image for the machine-api-provider-powervs image to UBI 9 Minimal to align with the OpenShift 4.21 release requirements for reducing CVE count and image size.

cc/ @prb112

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@prb112
Copy link

prb112 commented Nov 19, 2025

/jira-refresh

@Karthik-K-N
Copy link
Member

Seems like the ART team is going to take care of it https://redhat-internal.slack.com/archives/CBZHF4DHC/p1763611254086449

so we can wait till then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants