-
Notifications
You must be signed in to change notification settings - Fork 24
MULTIARCH-5801: switch to ubi-minimal image for 4.21 #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/ok-to-test |
|
Looks fine, as @yussufsh brought up - we want https://github.com/openshift/machine-api-provider-powervs/blob/main/Dockerfile.rhel to be updated in a similar way. |
Karthik-K-N
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
for confirmation about changes and testing.
| && GOPROXY=off NO_DOCKER=1 make build | ||
|
|
||
| FROM registry.ci.openshift.org/ocp/4.21:base-rhel9 | ||
| FROM registry.redhat.io/ubi9/ubi-minimal:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I not sure about this.
@damdo curious to know your thoughts, Are we supposed to update here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @Karthik-K-N This is in line with the instructions given at https://issues.redhat.com/browse/OCPSTRAT-2553
Teams will also need to ensure that all runtime dependencies, if any, are met if they were previously implicitly installed in the base image.
So you have to ensure that all the runtimes are installed and the project is working.
|
@aman4433: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| && GOPROXY=off NO_DOCKER=1 GOARCH=ppc64le make build | ||
|
|
||
| FROM --platform=ppc64le registry.access.redhat.com/ubi8/ubi:8.4 | ||
| FROM --platform=ppc64le registry.redhat.io/ubi9/ubi-minimal:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not needed at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may not be needed .But I feel good to keep same here for consistency.
prb112
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aman4433, prb112 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retitle MULTIARCH-5801: switch to ubi-minimal image for 4.21 |
|
@aman4433: This pull request references MULTIARCH-5801 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira-refresh |
|
Seems like the ART team is going to take care of it https://redhat-internal.slack.com/archives/CBZHF4DHC/p1763611254086449 so we can wait till then. |
This Pull Request updates the base image for the machine-api-provider-powervs image to UBI 9 Minimal to align with the OpenShift 4.21 release requirements for reducing CVE count and image size.
cc/ @prb112