Skip to content

Conversation

@sebrandon1
Copy link
Member

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

Tracking issue: redhat-best-practices-for-k8s/telco-bot#45

Copy link
Member

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR
Test failure is unrelated to this Platform

/lgtm
/approve

@Karthik-K-N
Copy link
Member

/test okd-scos-e2e-aws-ovn

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2025
@Karthik-K-N
Copy link
Member

/override okd-scos-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@Karthik-K-N: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • okd-scos-e2e-aws-ovn

Only the following failed contexts/checkruns were expected:

  • ci/prow/generate
  • ci/prow/goimports
  • ci/prow/golint
  • ci/prow/govet
  • ci/prow/images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/okd-scos-images
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify-deps
  • pull-ci-openshift-machine-api-provider-powervs-main-generate
  • pull-ci-openshift-machine-api-provider-powervs-main-goimports
  • pull-ci-openshift-machine-api-provider-powervs-main-golint
  • pull-ci-openshift-machine-api-provider-powervs-main-govet
  • pull-ci-openshift-machine-api-provider-powervs-main-images
  • pull-ci-openshift-machine-api-provider-powervs-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-machine-api-provider-powervs-main-okd-scos-images
  • pull-ci-openshift-machine-api-provider-powervs-main-security
  • pull-ci-openshift-machine-api-provider-powervs-main-unit
  • pull-ci-openshift-machine-api-provider-powervs-main-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Karthik-K-N
Copy link
Member

Since the failure is not related to the platform PowerVS

/override ci/prow/okd-scos-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@Karthik-K-N: Overrode contexts on behalf of Karthik-K-N: ci/prow/okd-scos-e2e-aws-ovn

Details

In response to this:

Since the failure is not related to the platform PowerVS

/override ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2025

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants