OCPBUGS-45308: PTP holdover time should be kept for 4 hours

[aneeshkp]

Enhancements to Logging and Clock Class Announcements for T-GM State Management

This PR introduces structured logging that includes the state tree, providing users with detailed insights into the relationships between all components involved in the Time Grandmaster (T-GM) state decision process. By exposing state transitions and dependencies, this enhancement simplifies troubleshooting and improves the overall observability of T-GM behavior.

Additionally, this PR removes the use of ClockClass 140 (OutOfSpec) and implements the following improvements:

• Announces ClockClass 6 during the LOCKED state.
• Announces ClockClass 7 during the HOLDOVER state until one of the following conditions is met:
  • The holdover duration times out.
  • The inSpecOffset threshold is reached.

These changes enhance state accuracy and ensure consistent clock class announcements.

[openshift-ci]

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@aneeshkp: This pull request references Jira Issue OCPBUGS-45308, which is invalid:

• expected the bug to target the "4.14.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-45308 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR introduces structured logging to include the state tree, enabling users to better understand the relationships between all components involved in the T-GM state decision process. By providing detailed insights into state transitions and dependencies, this enhancement aims to simplify troubleshooting .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vitus133]

/jira refresh

[openshift-ci-robot]

@vitus133: This pull request references Jira Issue OCPBUGS-45308, which is invalid:

• expected the bug to target the "4.14.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vitus133]

/jira refresh

[openshift-ci-robot]

@vitus133: This pull request references Jira Issue OCPBUGS-45308, which is valid. The bug has been moved to the POST state.

9 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-47520 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent bug Jira Issue OCPBUGS-47520 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-47520 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
• dependent Jira Issue OCPBUGS-47520 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vitus133]

/label backport-risk-assessed

[hhassid]

/label cherry-pick-approved

[vitus133]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aneeshkp,vitus133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@aneeshkp: Jira Issue OCPBUGS-45308: All pull requests linked via external trackers have merged:

• openshift/linuxptp-daemon#379
• redhat-cne/cloud-event-proxy#399

Jira Issue OCPBUGS-45308 has been moved to the MODIFIED state.

In response to this:

Enhancements to Logging and Clock Class Announcements for T-GM State Management

This PR introduces structured logging that includes the state tree, providing users with detailed insights into the relationships between all components involved in the Time Grandmaster (T-GM) state decision process. By exposing state transitions and dependencies, this enhancement simplifies troubleshooting and improves the overall observability of T-GM behavior.

Additionally, this PR removes the use of ClockClass 140 (OutOfSpec) and implements the following improvements:

• Announces ClockClass 6 during the LOCKED state.
• Announces ClockClass 7 during the HOLDOVER state until one of the following conditions is met:
• The holdover duration times out.
• The inSpecOffset threshold is reached.

These changes enhance state accuracy and ensure consistent clock class announcements.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: linuxptp-daemon
This PR has been included in build ose-linuxptp-daemon-container-v4.14.0-202501021036.p0.g0982992.assembly.stream.el9.
All builds following this will include this PR.