NO-JIRA: UPSTREAM: <drop>: Remove duplicate VolumeGroupSnapshottableTestSuite from CSISuites #2494
Conversation
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/test e2e-aws-ovn-techpreview |
|
/test e2e-aws-ovn-techpreview failed to build coreos image |
|
Only one |
|
Should the commit message be |
…from CSISuites The VolumeGroupSnapshot e2e test was running twice in CI, causing the second execution to fail with timeouts and crashes. The test suite initializer InitVolumeGroupSnapshottableTestSuite was incorrectly added to both BaseSuites and CSISuites. Since CSISuites is created by appending to BaseSuites, this caused the same test to be registered and executed twice. The second run would fail because it attempted to create volume group snapshot resources that were still cleaning up from the first successful run. This removes the duplicate entry from CSISuites, ensuring the test only runs once.
stbenjam
force-pushed
the
fix-duplicate-volumegroupsnapshot-test
branch
from
7bc7f23 to
d3c4628
Compare
|
@stbenjam: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
stbenjam
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@stbenjam: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
stbenjam
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@stbenjam: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified bypass |
openshift-ci-robot
added
the
verified
|
@stbenjam: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
The VolumeGroupSnapshot e2e test was running twice in CI, causing the second execution to fail with timeouts and crashes. The test suite initializer InitVolumeGroupSnapshottableTestSuite was incorrectly added to both BaseSuites and CSISuites. Since CSISuites is created by appending to BaseSuites, this caused the same test to be registered and executed twice. The second run would fail because it attempted to create volume group snapshot resources that were still cleaning up from the first successful run.
This removes the duplicate entry from CSISuites, ensuring the test only runs once.
Upstream already found this, but cherry-picking that entire change is a little more complex. kubernetes@d0a2a0d#diff-74a1bbe84c67d45f3d4e437f9dcfc98bcae740c9a88e05b803ef284f5a1f6ff0