-
Notifications
You must be signed in to change notification settings - Fork 125
OCPBUGS-46422: Remove patch/update from ServiceCIDR API conformance test #2466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
OCPBUGS-46422: Remove patch/update from ServiceCIDR API conformance test #2466
Conversation
…e test They were already listed in ineligible_endpoints.yaml, so we shouldn't be testing them here anyway. (cherry picked from commit 9d09997)
|
@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danwinship: the contents of this pull request could be automatically validated. The following commits are valid:
Comment |
|
/retest-required |
|
/jira refresh |
|
@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @bertinatto |
bertinatto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label backport-risk-assessed
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @danwinship This is just removing part of an e2e test, and this is identical to what already merged to master. |
|
@danwinship: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
filed openshift/release#70886 to shard the serial jobs to fix the timeouts... |
|
but you could also |
|
/retest |
|
/skip |
|
@danwinship: This pull request references Jira Issue OCPBUGS-46422. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/skip |
|
/retest but @bertinatto this may need an |
|
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/skip |
backport of #2444 to
release-4.20