Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-44787: [release-4.18] upstream 126750: consume u/s LLC alignment support #2130

Closed
wants to merge 3 commits into from
Closed

OCPBUGS-44787: [release-4.18] upstream 126750: consume u/s LLC alignment support #2130

wants to merge 3 commits into from

Conversation

ffromani
Copy link

@ffromani ffromani commented Nov 8, 2024 •
edited
Loading

Backport of upstream PR kubernetes#126750
includes openshift-specific code to enable the feature conditionally, in addition to the required feature gate enablement and policy option.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Nov 8, 2024
@openshift-ci-robot
Copy link

@ffromani: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from rphillips and sjenning November 8, 2024 14:32
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffromani
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sphrasavath and others added 2 commits November 18, 2024 10:10
@sphrasavath @ffromani
UPSTREAM: 126750: Add takeByTopologyUnCoreCachePacked if policy optio…
aa1cc78 
…n align-cpus-by-uncorecache is enabled.

 Adding new function to evaluate uncore cache id. Reverse allocation logic.
 Implement preferAlignByUncorecache within TakeByTopologyNUMAPacked, along with new test cases.

(cherry picked from commit 3f459f2)
@wongchar @ffromani
UPSTREAM: 126750: update comments
0f089fa 
(cherry picked from commit b86eb19)
@ffromani ffromani force-pushed the ocp-split-l3-cache-4.18 branch from 348a155 to a5d5a48 Compare November 18, 2024 09:10
@openshift-ci-robot
Copy link

@ffromani: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ffromani ffromani changed the title [release-4.18] WIP: NOMERGE: DNM: consume u/s LLC alignment support [release-4.18] upstream 126750: consume u/s LLC alignment support Nov 18, 2024
@ffromani
Copy link
Author

/cc @mrunalp @haircommander

@ffromani
Copy link
Author

/retest

1 similar comment
@ffromani
Copy link
Author

/retest

@ffromani
UPSTREAM: <carry>: require configuration file enablement
e84ead2 
similarly to what we do for the managed CPU (aka workload partitioning)
feature, introduce a master configuration file
`/etc/kubernetes/openshift-llc-alignment` which needs to be present for
the LLC alignment feature to be activated, in addition to the policy
option being required.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the ocp-split-l3-cache-4.18 branch from a5d5a48 to e84ead2 Compare November 19, 2024 16:19
@openshift-ci-robot
Copy link

@ffromani: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ffromani ffromani changed the title [release-4.18] upstream 126750: consume u/s LLC alignment support OCPBUGS-44787: [release-4.18] upstream 126750: consume u/s LLC alignment support Nov 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 20, 2024
@openshift-ci-robot
Copy link

@ffromani: This pull request references Jira Issue OCPBUGS-44787, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-44787 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of upstream PR kubernetes#126750
includes openshift-specific code to enable the feature conditionally, in addition to the required feature gate enablement and policy option.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ffromani
Copy link
Author

/hold

depends on #2136 (or we may want to drop and let automation do the work)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@ffromani
Copy link
Author

/retest

@ffromani ffromani mentioned this pull request Dec 10, 2024
Open
@ffromani
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@ffromani: This pull request references Jira Issue OCPBUGS-44787, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-44787 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ffromani
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@ffromani: This pull request references Jira Issue OCPBUGS-44787, which is invalid:

  • expected Jira Issue OCPBUGS-44787 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ffromani
Copy link
Author

master branch PR: #2136 (races with #2147)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024

@ffromani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn e84ead2 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani
Copy link
Author

closing in favor of automated #2162

@ffromani ffromani closed this Dec 11, 2024
@openshift-ci-robot
Copy link

@ffromani: This pull request references Jira Issue OCPBUGS-44787. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Backport of upstream PR kubernetes#126750
includes openshift-specific code to enable the feature conditionally, in addition to the required feature gate enablement and policy option.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphillips rphillips Awaiting requested review from rphillips

@sjenning sjenning Awaiting requested review from sjenning

@haircommander haircommander Awaiting requested review from haircommander

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffromani @openshift-ci-robot @sphrasavath @wongchar