-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: UPSTREAM: fix request Host storing in openshift.io/during-graceful audit log annotation #2119
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
@vrutkovs: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-kube-apiserver-rollout openshift/origin#29058 |
@vrutkovs: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6f39bfd0-904a-11ef-9689-ac0a7392141a-0 |
…aceful audit log annotation request URL doesn't contain the host used in the request, instead it should be fetched from request headers Note for rebase: squash it into the following commit a83d289 UPSTREAM: <carry>: annotate audit events for requests during unready phase and graceful termination phase
ac75c81
to
708b27f
Compare
@vrutkovs: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@vrutkovs: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@vrutkovs: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
request URL doesn't contain the host used in the request, instead it
should be fetched from request headers
Note for rebase: squash it into the following commit
vrutkovs@a83d289 UPSTREAM: : annotate audit events for requests during unready phase and graceful termination phase (#2077)