CORS-3724: bump go v1.23 and k8s dependencies#9396
CORS-3724: bump go v1.23 and k8s dependencies#9396patrickdillon merged 8 commits intoopenshift:mainfrom
Conversation
|
@tthvo: This pull request references CORS-3724 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/cc @patrickdillon |
|
/cc @2uasimojo |
@2uasimojo this is just a heads up, we have a note to let hive know whenver we bump k8s dependencies |
ack. Thanks! Bumped those images and rebased. |
|
I think we might also need to bump golint in CI to use version that support gov1.23 (that should be >= |
|
/retest |
|
|
It seems later version of golint detects additional lint errors (See error from rehearsal. Would you like me to include the changes in this PR too since we are bumping go version here? |
Yeah if you could take a stab at fixing those lint errors and include those in this PR that would be great. |
|
@tthvo Lets run a fixup on your last couple commits. Looks like you added a comment but we need to edit the commit for fixup too. |
The file .golangci.yaml contains configurations for golangci-lint. As golangci-lint version is bumped, some configurations are deprecated and moved/removed. With this patch, the file is now compatible. For gosec, we can safely exclude G115 (integer overflow converting between int types). For errcheck, we skip checking type assertions.
@patrickdillon The fixes are included in the recent commits :D I do have to adjust the
@barbacbd Thanks! I editted the commit for fixup now :D |
|
/approve This LGTM. I think golint is failing because openshift/release#60961 hasn't merged yet. I just put the labels on it, so it should merge quickly. We can then rerun golint. This LGTM pending tests. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest |
Oh, good catch. In that case, I think we should pin the version in CI. I thought using @tthvo will you fix what I did in openshift/release#60961 and pin to v1.64.3 (or another version of your choice)? |
|
hm edge zones test is failing due to failure to remove bootstrap ssh rules, not an issue with this pr, but this is a bug we thought we fixed: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/9396/pull-ci-openshift-installer-main-e2e-aws-ovn-edge-zones/1883011929534894080 I will investigate and open a new bug |
|
/label acknowledge-critical-fixes-only |
openshift-ci
Bot
added
the
acknowledge-critical-fixes-only
2 similar comments
Right, I opened the PR here: openshift/release#61015. I will push another commit in this PR to pin our local version in hack scripts to
I was wondering if it was related. Thanks for the explanation! |
Sync version with CI
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/skip |
|
/override ci/prow/e2e-azure-ovn-upi |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-azure-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
If this gets stuck I'm inclined to green button merge it. It has enough tests passing that I'm not concerned--although I will wait to see images and integration-tests pass |
|
/skip |
|
/override ci/prow/e2e-azure-ovn-upi |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-azure-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
5 participants
Release checklist: bump go v1.23 and update k8s deps (i.e.
v0.32.1)Note:
k8s.io/api@v0.32.1requires bumps go version to1.23.Commands: