Skip to content

Conversation

@jcpowermac
Copy link
Contributor

Changes
Modified IPAM creation logic to set apiVersion to v1beta2 when cluster capi operator is TP.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 17, 2025
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Jira Issue OCPBUGS-69434, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Changes
Modified IPAM creation logic to set apiVersion to v1beta2 when cluster capi operator is TP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor Author

/test e2e-vsphere-static-ovn

@jcpowermac
Copy link
Contributor Author

/cherry-pick release-4.21

@openshift-cherrypick-robot

@jcpowermac: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcpowermac
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview openshift/cluster-api#256

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2025

@jcpowermac: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/10d23290-db46-11f0-8441-a9ced9f47a4d-0

@damdo
Copy link
Member

damdo commented Dec 17, 2025

Supersedes #10158 #10168

@rvanderp3
Copy link
Contributor

/lgtm
/approve
/hold drop hold when ready

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025
@tthvo
Copy link
Member

tthvo commented Dec 17, 2025

/hold cancel

Looks good to me!

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025
@tthvo
Copy link
Member

tthvo commented Dec 17, 2025

/retest-required

@damdo
Copy link
Member

damdo commented Dec 17, 2025

/retitle SPLAT-2584,OCPBUGS-69434: Added ability to install different IPAM version when in TP.

@openshift-ci openshift-ci bot changed the title OCPBUGS-69434: Added ability to install different IPAM version when in TP. SPLAT-2584,OCPBUGS-69434: Added ability to install different IPAM version when in TP. Dec 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 17, 2025

@jcpowermac: This pull request references SPLAT-2584 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

This pull request references Jira Issue OCPBUGS-69434, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Changes
Modified IPAM creation logic to set apiVersion to v1beta2 when cluster capi operator is TP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member

tthvo commented Dec 17, 2025

/verified by payload testing and pre-submits

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 17, 2025
@openshift-ci-robot
Copy link
Contributor

@tthvo: This PR has been marked as verified by payload testing and pre-submits.

Details

In response to this:

/verified by payload testing and pre-submits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member

tthvo commented Dec 17, 2025

See testing for TechPreview in #10169 (comment) and Default in ci/prow/e2e-vsphere-static-ovn

@tthvo
Copy link
Member

tthvo commented Dec 17, 2025

/skip

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bee547d and 2 for PR HEAD f136b97 in total

@tthvo
Copy link
Member

tthvo commented Dec 17, 2025

/test okd-scos-images

@damdo
Copy link
Member

damdo commented Dec 17, 2025

@tthvo The okd image issue is being fixed here: openshift/release#72692

@tthvo
Copy link
Member

tthvo commented Dec 17, 2025

@tthvo The okd image issue is being fixed here: openshift/release#72692

Oh thank you! I didn't realized that 🙏

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fdf08d7 and 1 for PR HEAD f136b97 in total

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

/tide refresh

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

/test okd-scos-images

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@jcpowermac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn f136b97 link false /test okd-scos-e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member

damdo commented Dec 18, 2025

/tide refresh

@openshift-merge-bot openshift-merge-bot bot merged commit 63876c3 into openshift:main Dec 18, 2025
22 checks passed
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: Jira Issue OCPBUGS-69434: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-69434 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Changes
Modified IPAM creation logic to set apiVersion to v1beta2 when cluster capi operator is TP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@jcpowermac: new pull request created: #10174

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@tthvo: Jira Issue Verification Checks: Jira Issue OCPBUGS-69434
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-69434 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2025-12-18-234253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants