MachinePool: GCP: Custom UserTags #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new API field, MachinePool.Spec.GCP.UserTags, and plumb it into the GCP MachineSet generator. Results end up in the GCP's providerSpec.ResourceManagerTags (per upstream installer code at the time of this commit). NOTE: This commit breaks ground on a new way of enhancing hive's APIs based on the installer: We are including installer as a dependency in the `apis/` submodule for the first time to pull in the `UserTag` type by reference rather than copying it as we have done in the past. The dependency tooling seems smart enough to avoid pulling all of installer's transitive dependencies into the `apis/` submodule. We must be vigilant that this remains true going forward. HIVE-2512 (cherry picked from commit c758151)
openshift-ci
bot
added
the
approved
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mce-2.6 #2463 +/- ##
===========================================
- Coverage 58.61% 58.61% -0.01%
===========================================
Files 181 181
Lines 25820 25823 +3
===========================================
+ Hits 15134 15135 +1
- Misses 9413 9415 +2
Partials 1273 1273
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Sep 27, 2024
This is a special revendor. A prior commit (openshift#2463 / d8ebe58) included installer as a dependency in our apis/ package for the first time. This was causing problems for downstream consumers seemingly because the pseudo-version generated by `go mod` represented a years-old tag with a recent commit, resulting in excessive churn in the go sum database -- see the referenced bug report. Now a tag has been created at that commit to make this pseudo-version less gappy, hopefully eliminating this problem for downstreams. So this commit revendors to that tag, which computes to the same commit, so there is no actual change in vendoring -- only to go module metadata. OCPBUGS-42448 HIVE-2512
2uasimojo
added a commit
to 2uasimojo/hive
that referenced
this pull request
Sep 27, 2024
This is a special revendor. A prior commit (openshift#2463 / d8ebe58) included installer as a dependency in our apis/ package for the first time. This was causing problems for downstream consumers seemingly because the pseudo-version generated by `go mod` represented a years-old tag with a recent commit, resulting in excessive churn in the go sum database -- see the referenced bug report. Now a tag has been created at that commit to make this pseudo-version less gappy, hopefully eliminating this problem for downstreams. However, when I tried to revendor to that tag, go replaced it with a pseudo-version... and then complained that we shouldn't use a pseudo-version when there's a tag available!! (Shakes fist.) So this commit revendors to the _next_ commit, which should mean that a pseudo-version is the only way to reference it. The delta on that commit is null for vendoring purposes (the changed file is not one that makes its way into the vendor/ directory) so this is just a bump of pseudo-versions. OCPBUGS-42448 HIVE-2512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new API field, MachinePool.Spec.GCP.UserTags, and plumb it into the GCP MachineSet generator. Results end up in the GCP's providerSpec.ResourceManagerTags (per upstream installer code at the time of this commit).
NOTE: This commit breaks ground on a new way of enhancing hive's APIs based on the installer: We are including installer as a dependency in the
apis/submodule for the first time to pull in theUserTagtype by reference rather than copying it as we have done in the past. The dependency tooling seems smart enough to avoid pulling all of installer's transitive dependencies into theapis/submodule. We must be vigilant that this remains true going forward.HIVE-2512
(cherry picked from commit c758151)