-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KONFLUX-3663): format PipelineRun files and upload SAST results #2413
base: mce-2.5
Are you sure you want to change the base?
Conversation
Format PipelineRun files with yq for consistent indentation and format Signed-off-by: ccronca <[email protected]>
Configure the SAST task to upload SARIF results to quay.io for long-term storage Signed-off-by: ccronca <[email protected]>
Hi @ccronca. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, ccronca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@2uasimojo It looks like some security tests are failing, but they don't seem related to my change |
Yeah, that’s being addressed via #2387 – though it’s not going particularly well 😬 In any case, not part of this issue. /override ci/prow/security |
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ccronca: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@2uasimojo Btw, it looks like the hive-mce-25-on-pull-request check is failing. The issue seems to be with the clamav-scan task validation. I believe the image for this taskref bundle needs to be updated. This thread has some information about it |
@celebdor really needs to weigh in there. ISTR him talking about ripping konflux out of 2.5 anyway...? |
This update configures the SAST task to upload SARIF results to quay.io for long-term storage
Please note that this PR was automatically generated and may include unrelated changes due to automatic YAML formatting performed by
yq
The YAML files will be indented using 2 spaces, if the YAML file uses indentationless list the automation will try to keep this format
The PR contains two separate commits:
Separating these changes into two commits simplifies the review process. The first commit focuses on indentation and formatting, while the second commit contains the semantic changes
Related: