Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44769: Fix RWX mode for hyperdisks #74

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

dfajmon
Copy link

@dfajmon dfajmon commented Jan 23, 2025

Based on kubernetes-sigs#1901
We need to wait for upstream to merge these changes first.

/hold
/cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2025
@openshift-ci-robot
Copy link

@dfajmon: This pull request references Jira Issue OCPBUGS-44769, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-44769 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Based on kubernetes-sigs#1901

/hold
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 23, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
Copy link

openshift-ci bot commented Jan 23, 2025

@dfajmon: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Based on kubernetes-sigs#1901

/hold
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dfajmon dfajmon changed the title UPSTREAM: <carry>: OCPBUGS-44769: Fix RWX mode for hyperdisks OCPBUGS-44769: Fix RWX mode for hyperdisks Jan 23, 2025
Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfajmon
Once this PR has been reviewed and has the lgtm label, please assign dobsonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 23, 2025

@dfajmon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 87cea52 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chao007
Copy link

chao007 commented Jan 24, 2025

pod2                                                  1/1     Running   0               31s     10.131.2.7    qe-chaoyang124-nv2v9-worker-a-hzggn   <none>           <none>
pod3                                                  1/1     Running   0               116s    10.128.4.7    qe-chaoyang124-nv2v9-worker-g-fmbmb   <none>           <none>
❯ oc get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                        STORAGECLASS             VOLUMEATTRIBUTESCLASS   REASON   AGE
pvc-3cade150-cd7d-4345-912a-8d4c861840c6   6Gi        RWX            Delete           Bound    openshift-machine-api/pvc1   hyperdisk-balanced-rwx   <unset>                          2m4s
❯ oc get pvc
NAME   STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS             VOLUMEATTRIBUTESCLASS   AGE
pvc1   Bound    pvc-3cade150-cd7d-4345-912a-8d4c861840c6   6Gi        RWX            hyperdisk-balanced-rwx   <unset>                 2m56s

@chao007
Copy link

chao007 commented Jan 24, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants