NO-JIRA: Normalize generation of driver metrics RBAC proxy sidecar #380
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@stephenfin: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stephenfin
force-pushed
the
cleanup-driver-metrics
branch
from
9ebb32d to
4c9db2b
Compare
|
/retest |
No need to use a slice. Signed-off-by: Stephen Finucane <[email protected]>
The 'InjectKubeRBACProxy' field was was always set to True in users and was therefore a no-op. The 'Name' field was likewise always set to 'driver-m' and doesn't need to be templated. Flatten the remaining two fields into the parent structs are remove MetricsPorts entirely. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
This aligns us closer with the other sidecar containers own metrics sidecars. This is also, coincidentally, the first and only change in the series of changes that actually has an effect on the generated assets. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
cleanup-driver-metrics
branch
from
4c9db2b to
917c3be
Compare
openshift-ci
bot
requested review from
gnufied and
mandre
and removed request for
dobsonj
|
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The generator has the ability to generate kube-rbac-proxy sidecar containers when exposing driver metrics on the controller or node.
In #379, we noted that while the sidecar containers templates used template variables, the actual driver template used hardcoded strings. This allows for the possibility of bugs if the port numbers are changed at any point.
Resolve this by modifying the generator such that the metric port for the drivers is now templated also. Changes are implemented in multiple steps: I'd encourage reviewers to look at the individual commits.
This includes the commits from #379 and that can as such be considered a dependency.
Dependencies: