Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-4464: bump PatternFly 6 to latest available versions #14750

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Feb 10, 2025

We ultimately want to land on the latest official releases (e.g., 6.2.0), but this gets us closer to those final versions, providing time to vet the changes in the latest prerelease versions.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2025

@rhamilto: This pull request references CONSOLE-4464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

We ultimately want to land on the latest official releases (e.g., 6.2.0), but this gets us closer and provides time to vet the changes in the latest prerelease versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and jhadvig February 10, 2025 19:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2025

@rhamilto: This pull request references CONSOLE-4464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

We ultimately want to land on the latest official releases (e.g., 6.2.0), but this gets us closer to those final versions, providing time to vet the changes in the latest prerelease versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

/label acknowledge-critical-fixes-only

/assign @kmcfaul
/assign @yapei

Follow on for previously approved story, so adding labels
/label docs-approved
/label px-approved

Copy link
Contributor

openshift-ci bot commented Feb 10, 2025

@rhamilto: GitHub didn't allow me to assign the following users: kmcfaul.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/label acknowledge-critical-fixes-only

/assign @kmcfaul
/assign @yapei

Follow on for previously approved story, so adding labels
/label docs-approved
/label px-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Feb 10, 2025
@rhamilto
Copy link
Member Author

/retest

2 similar comments
@rhamilto
Copy link
Member Author

/retest

@rhamilto
Copy link
Member Author

/retest

"@patternfly/react-styles": "^6.2.0-prerelease.2",
"@patternfly/react-table": "^6.2.0-prerelease.16",
"@patternfly/react-templates": "^6.2.0-prerelease.16",
"@patternfly/react-tokens": "^6.2.0-prerelease.2",
"@patternfly/react-topology": "^6.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could wait for a prerelease for this package to pick up this fix? patternfly/react-topology#271

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can. The intention is for us to land on final versions. So there will probably be multiple PRs with version bumps.

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Feb 11, 2025
@rhamilto
Copy link
Member Author

/retest

@XiyunZhao
Copy link

no issue was found when build on local
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 12, 2025

@rhamilto: This pull request references CONSOLE-4464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

We ultimately want to land on the latest official releases (e.g., 6.2.0), but this gets us closer to those final versions, providing time to vet the changes in the latest prerelease versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2025
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5ebebcb and 2 for PR HEAD 1284989 in total

Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f77b81f into openshift:master Feb 13, 2025
7 checks passed
@rhamilto rhamilto deleted the CONSOLE-4464 branch February 13, 2025 13:01
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202502131239.p0.gf77b81f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants