OCPBUGS-61088: revert PR #2766 #2769

juzhao · 2025-12-03T01:36:58Z

This reverts commit 86d9e8c. PR: #2766
after the ROSA feature https://issues.redhat.com/browse/ROSA-634 is finished, we can merge the PR
/hold

…nfig_test.go and let CVO manage CMO networkpolicies" This reverts commit 86d9e8c.

openshift-ci-robot · 2025-12-03T01:37:04Z

@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit 86d9e8c.
after the ROSA feature https://issues.redhat.com/browse/ROSA-634 is finished, we can merge the PR
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

juzhao · 2025-12-03T01:38:06Z

/jira refresh

openshift-ci-robot · 2025-12-03T01:38:12Z

@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-12-03T01:38:15Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juzhao.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.21.0) matches configured target version for branch (4.21.0)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

juzhao · 2025-12-03T08:33:51Z

/retest

juzhao · 2025-12-03T08:34:10Z

/verified by @juzhao

openshift-ci-robot · 2025-12-03T08:34:23Z

@juzhao: This PR has been marked as verified by @juzhao.

Details

In response to this:

/verified by @juzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

machine424 · 2025-12-03T11:20:26Z

/lgtm

assets/cluster-monitoring-operator/network-policy-default-deny.yaml

juzhao · 2025-12-04T02:28:51Z

needs #2771 to merge first

juzhao · 2025-12-04T06:52:06Z

/retest-required

test/e2e/config_test.go

…nd move to e2e/main_test.go

juzhao · 2025-12-11T02:17:43Z

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn

openshift-ci · 2025-12-11T02:17:45Z

@juzhao: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/93bfeee0-d637-11f0-93cf-41f67e641e58-0

juzhao · 2025-12-11T02:35:27Z

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn-priv

openshift-ci · 2025-12-11T02:35:29Z

@juzhao: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

juzhao · 2025-12-11T02:46:49Z

/payload-job periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-gcp-techpreview
/payload-job periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-aws-single-node-insights-runtime-extractor-tests

openshift-ci · 2025-12-11T02:46:51Z

@juzhao: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-gcp-techpreview
periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-aws-single-node-insights-runtime-extractor-tests

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a4715270-d63b-11f0-9d47-d2274b61f61c-0

juzhao · 2025-12-11T05:47:51Z

rosa jobs cannot be triggered with /payload command, checked the insights job, the jobs are failed for its e2e test,
periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-gcp-techpreview job,

$ omc -n openshift-insights get po
NAME                                 READY   STATUS             RESTARTS   AGE
insights-operator-5948755868-4qpbj   1/1     Running            0          3m
insights-runtime-extractor-4p9wg     1/3     ImagePullBackOff   0          31m
insights-runtime-extractor-7z45g     1/3     ImagePullBackOff   0          31m
insights-runtime-extractor-rgkmh     1/3     ImagePullBackOff   0          31m

the ImagePullBackOff pod is caused by

    name: insights-runtime-extractor-4p9wg
    namespace: openshift-insights
    resourceVersion: "40429"
    uid: 7824246a-47ad-4af7-bda2-6c77701470a8
  kind: Event
  lastTimestamp: "2025-12-11T03:56:58Z"
  message: 'Failed to pull image "quay-proxy.ci.openshift.org/openshift/ci@sha256:9599d03f3dcbf1b3f0292c29d3c2be870e140636d1366b67f6bf62999af8d12f":
    unable to pull image or OCI artifact: pull image err: initializing source docker://quay-proxy.ci.openshift.org/openshift/ci@sha256:9599d03f3dcbf1b3f0292c29d3c2be870e140636d1366b67f6bf62999af8d12f:
    unable to retrieve auth token: invalid username/password: authentication required;
    artifact err: get manifest: build image source: unable to retrieve auth token:
    invalid username/password: authentication required'

failure is not caused by this PR, for the periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-aws-single-node-insights-runtime-extractor-tests job, insights pods are normal, it does not block the pods, example

$ omc get node
NAME                         STATUS   ROLES                         AGE   VERSION
ip-10-0-9-199.ec2.internal   Ready    control-plane,master,worker   43m   v1.34.2

$ omc -n openshift-insights get po
NAME                                 READY   STATUS    RESTARTS   AGE
insights-operator-769f859f57-77skq   1/1     Running   0          10m
insights-runtime-extractor-l9bkj     3/3     Running   2          39m

$ omc get co insights
NAME       VERSION                                                    AVAILABLE   PROGRESSING   DEGRADED   SINCE
insights   4.21.0-0.ci-2025-12-11-025120-test-ci-op-nvm9niid-latest   True        False         False      40m

juzhao · 2025-12-11T06:58:26Z

/payload-job periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-gcp-techpreview

openshift-ci · 2025-12-11T06:58:30Z

@juzhao: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-gcp-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb9513a0-d65e-11f0-85bf-a8b612915d0f-0

juzhao · 2025-12-11T11:44:07Z

retested periodic-ci-openshift-insights-operator-release-4.21-periodics-e2e-gcp-techpreview job, failed for the same error

$ omc -n openshift-insights get po
NAME                                 READY   STATUS             RESTARTS   AGE
insights-operator-69fd87547b-flxxv   1/1     Running            0          4m
insights-runtime-extractor-5jjk6     1/3     ImagePullBackOff   0          25m
insights-runtime-extractor-82pvw     1/3     ImagePullBackOff   0          25m
insights-runtime-extractor-xq4sb     3/3     Running            0          25m
periodic-archive-7q0av               1/1     Running            0          9m
periodic-gathering-q9tpz-gspdg       0/1     Completed          0          4m
test-subset-disable-df30z-archive    1/1     Running            0          9m
test-subset-disable-df30z-fhbf6      1/1     Running            0          9m

    kind: Pod
    name: insights-runtime-extractor-5jjk6
    namespace: openshift-insights
    resourceVersion: "39535"
    uid: 478d64fa-746e-48c1-8923-4ed099cb74db
  kind: Event
  lastTimestamp: "2025-12-11T08:48:04Z"
  message: 'Failed to pull image "quay-proxy.ci.openshift.org/openshift/ci@sha256:9599d03f3dcbf1b3f0292c29d3c2be870e140636d1366b67f6bf62999af8d12f":
    unable to pull image or OCI artifact: pull image err: initializing source docker://quay-proxy.ci.openshift.org/openshift/ci@sha256:9599d03f3dcbf1b3f0292c29d3c2be870e140636d1366b67f6bf62999af8d12f:
    unable to retrieve auth token: invalid username/password: authentication required;
    artifact err: get manifest: build image source: unable to retrieve auth token:
    invalid username/password: authentication required'

insights QE tested on the cluster-bot cluster with the PR, no such issue(maybe the case should be enhanced), we can ignore, this PR does not block insights

openshift-bot · 2025-12-12T08:26:51Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2025-12-12T08:28:05Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-61088, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

juzhao · 2025-12-15T05:59:55Z

/jira refresh

openshift-ci-robot · 2025-12-15T06:00:01Z

@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-12-15T06:00:09Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juzhao.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.22.0) matches configured target version for branch (4.22.0)

bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

juzhao · 2025-12-15T07:27:42Z

/hold cancel

juzhao · 2025-12-15T07:28:33Z

@machine424 I think we can add acknowledge-critical-fixes-only label now, main branch is 4.22

simonpasquier · 2025-12-15T16:00:37Z

/label acknowledge-critical-fixes-only
/hold

juzhao · 2025-12-17T12:44:57Z

/unhold

openshift-ci-robot · 2025-12-17T13:49:06Z

/retest-required

Remaining retests: 0 against base HEAD fa0bed2 and 2 for PR HEAD 843e140 in total

juzhao · 2025-12-18T01:18:40Z

/retest-required

openshift-ci · 2025-12-18T03:40:46Z

@juzhao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-images	`843e140`	link	true	`/test okd-scos-images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Reapply "OCPBUGS-61088: revert PR openshift#2738, enhance test for co…

6aa4b10

…nfig_test.go and let CVO manage CMO networkpolicies" This reverts commit 86d9e8c.

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 3, 2025

openshift-ci bot requested review from danielmellado and marioferh December 3, 2025 01:37

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 3, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 3, 2025

openshift-ci bot assigned machine424 Dec 3, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 3, 2025

machine424 reviewed Dec 3, 2025

View reviewed changes

assets/cluster-monitoring-operator/network-policy-default-deny.yaml Outdated Show resolved Hide resolved

update default-deny NP podSelector

2ccdb99

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Dec 4, 2025

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025

machine424 reviewed Dec 4, 2025

View reviewed changes

test/e2e/config_test.go Outdated Show resolved Hide resolved

update assertInClusterNetworkPolicyExists func to TestNetworkPolicy a…

0c85699

…nd move to e2e/main_test.go

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2025

Merge branch 'main' into revert_2766

e764f42

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 12, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 15, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2025

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. labels Dec 15, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025

OCPBUGS-61088: revert PR #2766 #2769

Are you sure you want to change the base?

OCPBUGS-61088: revert PR #2766 #2769

Conversation

juzhao commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 3, 2025

Uh oh!

juzhao commented Dec 3, 2025

Uh oh!

openshift-ci-robot commented Dec 3, 2025

Uh oh!

openshift-ci bot commented Dec 3, 2025

Uh oh!

juzhao commented Dec 3, 2025

Uh oh!

juzhao commented Dec 3, 2025

Uh oh!

openshift-ci-robot commented Dec 3, 2025

Uh oh!

machine424 commented Dec 3, 2025

Uh oh!

Uh oh!

juzhao commented Dec 4, 2025

Uh oh!

juzhao commented Dec 4, 2025

Uh oh!

Uh oh!

juzhao commented Dec 11, 2025

Uh oh!

openshift-ci bot commented Dec 11, 2025

Uh oh!

juzhao commented Dec 11, 2025

Uh oh!

openshift-ci bot commented Dec 11, 2025

Uh oh!

juzhao commented Dec 11, 2025

Uh oh!

openshift-ci bot commented Dec 11, 2025

Uh oh!

juzhao commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juzhao commented Dec 11, 2025

Uh oh!

openshift-ci bot commented Dec 11, 2025

Uh oh!

juzhao commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

juzhao commented Dec 15, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025

Uh oh!

openshift-ci bot commented Dec 15, 2025

Uh oh!

juzhao commented Dec 15, 2025

Uh oh!

juzhao commented Dec 15, 2025

Uh oh!

simonpasquier commented Dec 15, 2025

Uh oh!

juzhao commented Dec 17, 2025

Uh oh!

openshift-ci-robot commented Dec 17, 2025

Uh oh!

juzhao commented Dec 18, 2025

Uh oh!

openshift-ci bot commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

juzhao commented Dec 3, 2025 •

edited

Loading

juzhao commented Dec 11, 2025 •

edited

Loading

juzhao commented Dec 11, 2025 •

edited

Loading