Skip to content

NO-ISSUE: Bump openshift/library-go #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 24, 2025
Merged

NO-ISSUE: Bump openshift/library-go #2751

openshift-merge-bot merged 1 commit into from
Nov 24, 2025

Conversation

@simonpasquier
Copy link
Contributor

@simonpasquier simonpasquier commented Nov 20, 2025

This commit pulls openshift/library-go#2051.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
slashpai
slashpai reviewed Nov 20, 2025
View reviewed changes
Copy link
Member

@slashpai slashpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@simonpasquier
Bump openshift/library-go
5f2ad71 
This commit pulls openshift/library-go#2051.

Signed-off-by: Simon Pasquier <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@simonpasquier
Copy link
Contributor Author

simonpasquier commented Nov 20, 2025

/skip

@simonpasquier simonpasquier changed the title Bump openshift/library-go NO-ISSUE: Bump openshift/library-go Nov 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2025

@simonpasquier: This pull request explicitly references no jira issue.

Details

In response to this:

This commit pulls openshift/library-go#2051.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2025
@simonpasquier
Copy link
Contributor Author

simonpasquier commented Nov 21, 2025

/retest-required

2 similar comments
@simonpasquier
Copy link
Contributor Author

simonpasquier commented Nov 21, 2025

/retest-required

@simonpasquier
Copy link
Contributor Author

simonpasquier commented Nov 21, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025 •
edited
Loading

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 5f2ad71 link false /test versions

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@juzhao
Copy link
Contributor

juzhao commented Nov 24, 2025

/retest-required

@slashpai
Copy link
Member

slashpai commented Nov 24, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor Author

simonpasquier commented Nov 24, 2025

/verified by e2e tests

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 24, 2025

@simonpasquier: This PR has been marked as verified by e2e tests.

Details

In response to this:

/verified by e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e4ba303 into openshift:main Nov 24, 2025
20 checks passed
@juzhao juzhao mentioned this pull request Nov 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@machine424 machine424 Awaiting requested review from machine424

1 more reviewer

@slashpai slashpai slashpai left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@slashpai slashpai

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonpasquier @openshift-ci-robot @juzhao @slashpai