MON-3858: Add support to sysctl node-exporter collector #2339

cgoncalves · 2024-05-07T13:50:54Z

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

cgoncalves · 2024-05-07T13:55:33Z

cc @danielmellado

danielmellado · 2024-05-14T07:41:45Z

Seems to be pretty much in line with all other collectors, thanks Carlos!

danielmellado · 2024-05-14T07:41:50Z

/lgtm

simonpasquier · 2024-05-14T08:00:17Z

/hold

pkg/manifests/types.go

pkg/manifests/manifests.go

openshift-ci · 2024-06-03T10:41:32Z

New changes are detected. LGTM label has been removed.

openshift-ci-robot · 2024-06-03T13:17:12Z

@cgoncalves: This pull request references MON-3858 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

Details

In response to this:

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-09-30T01:01:00Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

cgoncalves · 2024-09-30T06:59:10Z

/remove-lifecycle stale

cgoncalves · 2024-11-12T12:16:13Z

/retest

cgoncalves · 2024-11-22T09:46:40Z

@simonpasquier, @danielmellado: please review. Thank you!

CHANGELOG.md

openshift-bot · 2025-04-18T09:00:32Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2025-05-19T00:30:12Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-ci · 2025-08-21T09:04:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, danielmellado

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [danielmellado]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2025-10-17T00:30:44Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2025-11-17T00:01:23Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2025-11-17T00:01:48Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cgoncalves · 2025-11-17T08:23:49Z

/reopen

Awaiting reviews...

openshift-ci · 2025-11-17T08:24:01Z

@cgoncalves: Reopened this PR.

Details

In response to this:

/reopen

Awaiting reviews...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-11-17T08:24:02Z

@cgoncalves: This pull request references MON-3858 which is a valid jira issue.

Details

In response to this:

I added CHANGELOG entry for this change.

No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Carlos Goncalves <[email protected]>

cgoncalves · 2025-12-15T09:27:08Z

@danielmellado @simonpasquier @marioferh @juzhao please review.

openshift-ci · 2025-12-15T12:24:53Z

@cgoncalves: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`cee1ee3`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/versions	`46b5cf9`	link	false	`/test versions`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

simonpasquier · 2025-12-17T17:11:03Z

/skip

simonpasquier

Can you add a sub-test for the collector to test/e2e/node_exporter_test.go?

simonpasquier · 2025-12-17T17:17:52Z

pkg/manifests/manifests.go

 	return args
 }

+func uniqueSet(input []string) []string {


can be replaced by https://pkg.go.dev/slices#Compact?

simonpasquier · 2025-12-17T17:18:59Z

/remove-lifecycle stale

simonpasquier · 2025-12-17T17:19:15Z

/remove-lifecycle rotten

simonpasquier · 2025-12-17T17:19:51Z

/hold cancel

cgoncalves force-pushed the sysctl_collector branch from f218f5f to b5f423f Compare May 7, 2024 13:52

openshift-ci bot requested review from danielmellado and marioferh May 7, 2024 13:54

cgoncalves force-pushed the sysctl_collector branch from b5f423f to 22d12ee Compare May 7, 2024 17:30

openshift-ci bot assigned danielmellado May 14, 2024

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024

simonpasquier reviewed May 14, 2024

View reviewed changes

cgoncalves force-pushed the sysctl_collector branch from 22d12ee to c90f629 Compare June 3, 2024 10:41

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024

cgoncalves changed the title ~~Add support to sysctl node-exporter collector~~ MON-3858: Add support to sysctl node-exporter collector Jun 3, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2024

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024

juzhao reviewed Nov 28, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

cgoncalves force-pushed the sysctl_collector branch from c90f629 to c9bcba2 Compare December 2, 2024 09:06

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2025

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2025

cgoncalves force-pushed the sysctl_collector branch from c9bcba2 to 53bb4c2 Compare August 21, 2025 09:03

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2025

cgoncalves force-pushed the sysctl_collector branch from 53bb4c2 to 5d583fd Compare August 25, 2025 07:10

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 17, 2025

cgoncalves force-pushed the sysctl_collector branch from 5d583fd to cee1ee3 Compare October 17, 2025 08:21

openshift-ci bot closed this Nov 17, 2025

openshift-ci bot reopened this Nov 17, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2025

Add support to sysctl node-exporter collector

46b5cf9

Signed-off-by: Carlos Goncalves <[email protected]>

cgoncalves force-pushed the sysctl_collector branch from cee1ee3 to 46b5cf9 Compare December 15, 2025 09:25

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2025

simonpasquier reviewed Dec 17, 2025

View reviewed changes

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 17, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025

MON-3858: Add support to sysctl node-exporter collector #2339

Are you sure you want to change the base?

MON-3858: Add support to sysctl node-exporter collector #2339

Uh oh!

Conversation

cgoncalves commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgoncalves commented May 7, 2024

Uh oh!

danielmellado commented May 14, 2024

Uh oh!

danielmellado commented May 14, 2024

Uh oh!

simonpasquier commented May 14, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Jun 3, 2024

Uh oh!

openshift-ci-robot commented Jun 3, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Sep 30, 2024

Uh oh!

cgoncalves commented Sep 30, 2024

Uh oh!

cgoncalves commented Nov 12, 2024

Uh oh!

cgoncalves commented Nov 22, 2024

Uh oh!

Uh oh!

openshift-bot commented Apr 18, 2025

Uh oh!

openshift-bot commented May 19, 2025

Uh oh!

openshift-ci bot commented Aug 21, 2025

Uh oh!

openshift-bot commented Oct 17, 2025

Uh oh!

openshift-bot commented Nov 17, 2025

Uh oh!

openshift-ci bot commented Nov 17, 2025

Uh oh!

cgoncalves commented Nov 17, 2025

Uh oh!

openshift-ci bot commented Nov 17, 2025

Uh oh!

openshift-ci-robot commented Nov 17, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cgoncalves commented Dec 15, 2025

Uh oh!

openshift-ci bot commented Dec 15, 2025

Uh oh!

simonpasquier commented Dec 17, 2025

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

simonpasquier Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

simonpasquier commented Dec 17, 2025

Uh oh!

simonpasquier commented Dec 17, 2025

Uh oh!

simonpasquier commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

cgoncalves commented May 7, 2024 •

edited

Loading

openshift-ci-robot commented Jun 3, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 17, 2025 •

edited by openshift-ci bot

Loading