CORS-4204: Support Storage Endpoint override #1253

barbacbd · 2025-09-04T10:54:53Z

** Go Get update on openshift/api. github.com/openshift/api v0.0.0-20250806102053-6a7223edb2fc ** Go mod vendor (requires updates to numerous packages).

openshift-ci-robot · 2025-09-04T10:54:57Z

@barbacbd: This pull request references CORS-4204 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

** Go Get update on openshift/api. github.com/openshift/api v0.0.0-20250806102053-6a7223edb2fc ** Go mod vendor (requires updates to numerous packages).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

barbacbd · 2025-09-04T10:55:54Z

/cc @flavianmissi

barbacbd · 2025-09-04T10:56:31Z

/hold

** Go Get update on openshift/api. github.com/openshift/api v0.0.0-20250806102053-6a7223edb2fc ** Go mod vendor (requires updates to numerous packages).

barbacbd · 2025-09-04T19:04:45Z

/hold cancel

openshift-ci-robot · 2025-09-04T19:04:50Z

@barbacbd: This pull request references CORS-4204 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

** Go Get update on openshift/api. github.com/openshift/api v0.0.0-20250806102053-6a7223edb2fc ** Go mod vendor (requires updates to numerous packages).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

** Add Clock to the `configv1helpers.SetStatusCondition`, because the number of arguments changed to 3 to include a clock. RealClock{} is passed.

** Pass the feature gates to the GCS driver. ** Search for the correct featuregate and grab the service endpoints. When the endpoint for the storage api is provided, then use the endpoint to override the endpoint when the client is created.

** Update tests to include fake feature gate information. pkg/storage/swift: ** Update test to stop complaining about bad string formatting.

barbacbd · 2025-09-08T10:59:36Z

/retest-required

barbacbd · 2025-09-08T17:09:18Z

/retest-required

flavianmissi · 2025-09-09T07:28:57Z

it looks like more tests have become flaky in the e2e-*-operator suite, particularly the TestScaleUp.
I'm hoping a couple more retests can help them pass 🤞🏼

/retest

barbacbd · 2025-09-09T13:17:37Z

/test e2e-gcp-operator

barbacbd · 2025-09-09T13:18:17Z

/retets-required

barbacbd · 2025-09-10T14:29:43Z

/retest-required

barbacbd · 2025-09-11T13:37:36Z

/retest-required

flavianmissi · 2025-09-12T12:59:54Z

/test e2e-gcp-operator
/test e2e-aws-operator

flavianmissi · 2025-09-15T09:05:02Z

TestScaleUp is consistently failing on gcp. The image-registry operator is going degraded:

          - lastTransitionTime: "2025-09-12T14:44:10Z"
            message: 'Registry deployment has timed out progressing: ReplicaSet "image-registry-689fc5dcc"
              has timed out progressing.'
            reason: ProgressDeadlineExceeded
            status: "True"
            type: Degraded

As far as I can tell this test is perma-failing on gcp and azure. It's extremely flaky on aws but it does pass there.

I triggered the e2e-gcp-operator from another PR to see if the issue shows up there as well: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-image-registry-operator/1257/pull-ci-openshift-cluster-image-registry-operator-main-e2e-gcp-operator/1967513228040736768

I'll override these tests if we observe them failing on other PRs too.

flavianmissi · 2025-09-18T11:32:14Z

These operator tests are flaking more and more :( The one I ran on a different PR also failed on TestScaleUp. We need to open a tracker on jira and look into it.

I'll override the test here so we can unblock this PR.
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-gcp-operator
/override ci/prow/e2e-azure-operator

openshift-ci · 2025-09-18T11:32:52Z

@flavianmissi: Overrode contexts on behalf of flavianmissi: ci/prow/e2e-aws-operator, ci/prow/e2e-azure-operator, ci/prow/e2e-gcp-operator

In response to this:

These operator tests are flaking more and more :( The one I ran on a different PR also failed on TestScaleUp. We need to open a tracker on jira and look into it.

I'll override the test here so we can unblock this PR.
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-gcp-operator
/override ci/prow/e2e-azure-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

flavianmissi · 2025-09-18T11:35:18Z

/approve

barbacbd · 2025-09-19T13:58:11Z

/verifed by ci/prow/e2e-gcp-ovn

patrickdillon · 2025-09-22T19:09:11Z

/lgtm

openshift-ci · 2025-09-22T19:10:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, flavianmissi, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

flavianmissi · 2025-09-23T11:38:24Z

installer docs should cover the changes in here. since this change is an extension of platform functionality I don't think we need to involve IR PX either.

/label px-approved
/label docs-approved

@xiuwang could you please help with verification?

openshift-ci · 2025-10-01T14:45:47Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2025-10-01T19:09:47Z

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`b567dee`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-gcp-ovn	`b567dee`	link	false	`/test e2e-gcp-ovn`
ci/prow/e2e-azure-operator	`b567dee`	link	false	`/test e2e-azure-operator`
ci/prow/verify	`b567dee`	link	true	`/test verify`
ci/prow/e2e-gcp-operator	`b567dee`	link	false	`/test e2e-gcp-operator`
ci/prow/e2e-openstack	`b567dee`	link	false	`/test e2e-openstack`
ci/prow/e2e-vsphere-operator	`b567dee`	link	true	`/test e2e-vsphere-operator`
ci/prow/verify-deps	`b567dee`	link	true	`/test verify-deps`
ci/prow/e2e-aws-operator	`b567dee`	link	true	`/test e2e-aws-operator`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 4, 2025

openshift-ci bot requested review from flavianmissi and ricardomaraschini September 4, 2025 10:55

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2025

barbacbd added 2 commits September 4, 2025 14:28

CORS-4204: Support Storage Endpoint override

344ec3d

** Go Get update on openshift/api. github.com/openshift/api v0.0.0-20250806102053-6a7223edb2fc ** Go mod vendor (requires updates to numerous packages).

** go.mod and go.sum package updates

78b288f

barbacbd force-pushed the gcp_custom_endpoint branch from d9c4fe9 to 8b5e82e Compare September 4, 2025 19:04

barbacbd closed this Sep 4, 2025

barbacbd reopened this Sep 4, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2025

barbacbd force-pushed the gcp_custom_endpoint branch from 8e0328d to fa0d4cf Compare September 5, 2025 10:59

pkg/resource/clusteroperator.go:

0ff924c

** Add Clock to the `configv1helpers.SetStatusCondition`, because the number of arguments changed to 3 to include a clock. RealClock{} is passed.

barbacbd force-pushed the gcp_custom_endpoint branch from fa0d4cf to b14707d Compare September 5, 2025 12:31

barbacbd added 2 commits September 5, 2025 13:54

pkg/storage:

803c0d8

** Pass the feature gates to the GCS driver. ** Search for the correct featuregate and grab the service endpoints. When the endpoint for the storage api is provided, then use the endpoint to override the endpoint when the client is created.

pkg/storage/gcs:

f666b47

** Update tests to include fake feature gate information. pkg/storage/swift: ** Update test to stop complaining about bad string formatting.

barbacbd force-pushed the gcp_custom_endpoint branch from b14707d to f666b47 Compare September 5, 2025 17:54

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2025

openshift-ci bot assigned patrickdillon Sep 22, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 23, 2025

Debug: Adding debugging statement to determine the storage endpoint

b567dee

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025

CORS-4204: Support Storage Endpoint override #1253

Are you sure you want to change the base?

CORS-4204: Support Storage Endpoint override #1253

Uh oh!

Conversation

barbacbd commented Sep 4, 2025

Uh oh!

openshift-ci-robot commented Sep 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barbacbd commented Sep 4, 2025

Uh oh!

barbacbd commented Sep 4, 2025

Uh oh!

barbacbd commented Sep 4, 2025

Uh oh!

openshift-ci-robot commented Sep 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barbacbd commented Sep 8, 2025

Uh oh!

barbacbd commented Sep 8, 2025

Uh oh!

flavianmissi commented Sep 9, 2025

Uh oh!

barbacbd commented Sep 9, 2025

Uh oh!

barbacbd commented Sep 9, 2025

Uh oh!

barbacbd commented Sep 10, 2025

Uh oh!

barbacbd commented Sep 11, 2025

Uh oh!

flavianmissi commented Sep 12, 2025

Uh oh!

flavianmissi commented Sep 15, 2025

Uh oh!

flavianmissi commented Sep 18, 2025

Uh oh!

openshift-ci bot commented Sep 18, 2025

Uh oh!

flavianmissi commented Sep 18, 2025

Uh oh!

barbacbd commented Sep 19, 2025

Uh oh!

patrickdillon commented Sep 22, 2025

Uh oh!

openshift-ci bot commented Sep 22, 2025

Uh oh!

flavianmissi commented Sep 23, 2025

Uh oh!

openshift-ci bot commented Oct 1, 2025

Uh oh!

openshift-ci bot commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openshift-ci-robot commented Sep 4, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 4, 2025 •

edited by openshift-ci bot

Loading