Skip to content

Conversation

@tchap
Copy link

@tchap tchap commented Nov 11, 2025

This effectively enforces user namespace.

This effectively enforces user namespace.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@tchap: This pull request references CNTRLPLANE-1544 which is a valid jira issue.

Details

In response to this:

This effectively enforces user namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Walkthrough

The config operator deployment manifest has been updated with enhanced security constraints. Changes include updating the required SCC annotation from nonroot-v2 to restricted-v3, adding spec.hostUsers: false, and removing the specific securityContext.runAsUser value while maintaining runAsNonRoot: true.

Changes

Cohort / File(s) Summary
Security Configuration Updates
manifests/0000_10_config-operator_07_deployment.yaml
Updated SCC annotation from nonroot-v2 to restricted-v3; added spec.hostUsers: false; removed securityContext.runAsUser: 65534

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that the stricter SCC annotation (restricted-v3) is compatible with the config operator's runtime requirements
  • Confirm that removing the explicit runAsUser value does not cause unexpected permission or execution issues
  • Validate that hostUsers: false aligns with operational constraints and doesn't break pod networking or process isolation
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 347bebc and f1f99d6.

📒 Files selected for processing (1)
  • manifests/0000_10_config-operator_07_deployment.yaml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • manifests/0000_10_config-operator_07_deployment.yaml
🔇 Additional comments (1)
manifests/0000_10_config-operator_07_deployment.yaml (1)

24-24: No issues found—SCC and user namespace changes are compatible with the operator.

The operator code contains no hardcoded UID/GID assumptions, file permission operations, or host-level resource access. The deployment enforces runAsNonRoot: true with hostUsers: false, enabling user namespace isolation while keeping capabilities dropped to ["ALL"] and blocking privilege escalation. The change from nonroot-v2 to restricted-v3 SCC is safe and aligns with the security hardening objective.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k November 11, 2025 14:11
@tchap
Copy link
Author

tchap commented Nov 12, 2025

/retest

2 similar comments
@tchap
Copy link
Author

tchap commented Nov 12, 2025

/retest

@tchap
Copy link
Author

tchap commented Nov 13, 2025

/retest

@ropatil010
Copy link

/test e2e-aws-serial-techpreview-1of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants