-
Notifications
You must be signed in to change notification settings - Fork 25
TRT-2473: Revert "Pin IPAM CRDs to release-4.20" #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@neisw: This pull request references TRT-2473 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@neisw: This pull request references TRT-2473 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neisw The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade |
|
@neisw: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b505fcb0-d633-11f0-9515-060a5767e64c-0 |
|
/pipeline-required |
c3abbf2 to
9148e2d
Compare
|
@neisw: This PR was included in a payload test run from openshift/api#2617
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d46da960-d636-11f0-8a55-939474e54294-0 |
|
/lgtm |
|
/test e2e-vsphere-staticip-ipam-ovn |
|
/override ci/prow/e2e-vsphere-staticip-ipam-ovn New job for this attempted fix that we expect to be broken with the revert |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-vsphere-staticip-ipam-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@neisw: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
label /approved |
|
@neisw: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label approved |
|
@neisw: This PR was included in a payload test run from openshift/origin#30586
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aa700710-d67d-11f0-9eb6-b58676753e73-0 |
|
/hold |
|
We are already investigating this in another thread. |
|
Reverting this would be a mistake. We should not revert this. We already understand why this breaks. If we revert it, we will still have to re-apply the same fix, and we will still have to address this issue. We should address it now, instead. I will write up a detailed timeline with all the details shortly. |
|
/close After reviewing timelines on when the root issue came in: #243 12/3 and the fact it was not yet in a released EC we manually accepted payloads to get micro upgrades unstuck |
|
@neisw: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@neisw: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#900
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3ba3f640-d6f8-11f0-9224-5e46dbc55cc5-0 |
|
@neisw: This PR was included in a payload test run from openshift/machine-config-operator#5489
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/03eb04e0-d6f9-11f0-8261-7255b3fcf62c-0 |
|
@neisw: This PR was included in a payload test run from openshift/origin#30604
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/df1743d0-d6f9-11f0-82e3-520759d1a342-0 |
|
@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#900
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dab13350-d735-11f0-8fed-fcd0fe4ceb51-0 |
|
@neisw: This PR was included in a payload test run from openshift/machine-config-operator#5489
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b521a1b0-d749-11f0-9c6f-49bba9ef02f5-0 |
|
@ngopalak-redhat: This PR was included in a payload test run from openshift/machine-config-operator#5491
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/528debb0-d755-11f0-826b-d2c4b80a4f0a-0 |
|
@neisw: This PR was included in a payload test run from openshift/machine-config-operator#5489
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7c333c90-d755-11f0-917b-f286c81cb85b-0 |
|
@neisw: This PR was included in a payload test run from openshift/machine-config-operator#5489
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/80db55f0-d757-11f0-9eab-e3cee46cb112-0 |
|
@ngopalak-redhat: This PR was included in a payload test run from openshift/machine-config-operator#5491
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a07ff0e0-da55-11f0-885e-d2dbc5e46d89-0 |
|
@ngopalak-redhat: This PR was included in a payload test run from openshift/machine-config-operator#5491
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/953e4e20-daf0-11f0-88c3-4525b8822acb-0 |
Reverts #253
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
Multiple payload failures due to console-operator panic
To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:
CC: @mdbooth