Merge https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix:v1.8.3 (c9a2f46) into main #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Support multiple values by category * fix: nix-action version name change * removing flatmaps and keeping useCategoryMapping * fixing additional categories E2E * fixing additional categories E2E * using assertion in test, Addressing comments * addressing comments * reverting vals changes
Used by clusterctl to avoid GitHub API rate limits.
…oud-native#597) * Add cache methods and types for converged v4 client * Add more tests and add converged client to NutanixMachine controller context * Add more tests * Change prism-go-client to current main * go.sum fix
* fix: support multiple cintainer engine * changing name from setup_container_engine to select_container_engine
…d-native#598) * Change DeleteVM helper to converged v4 client * Add and fix test cases
…native#600) * V4 migration: GetImage and GetImageByLookup * Fix OData filter for image list call * Add tests and optimize GetImageByLookup * Fix linter error * Fix GetImageByLookup * Restore ImageLookup original behaviour
…cloud-native#602) * refactor: list storage containers using converged client * fix: uuid from containerExtId * fix: expected error strs
…ve#607) * feat: Add category method for converged v4 client * fix: name change from categoryValue to categories * fix: resolving conflicts to main * feat: Change GetSubnetUUID and GetSubnetUUIDList helper to work with V4 API (converged client) (nutanix-cloud-native#608) * feat: Change GetSubnetUUID and GetSubnetUUIDList helper to work with V4 API (converged client) * feat: Change GetPEUUID helper to work with V4 API (converged client) (nutanix-cloud-native#609) * resolving import conflict
…lient (nutanix-cloud-native#614) * Change GetTaskUUIDFromVM helper to work with V4 converged client * Fixed case for v3-v4 task id incompatibility and add more tests * Fix filter whitespaces and braces * Fix lint and unit tests errors after merge
…ative#604) * v4 migration GPU methods * Add gpu tests to PR test suite Add missing gpu vars to e2e env Fix gpu e2e and fix vars * Change labels for gpu and ensure that whitespace will not affect GPU name * get rid of extra quotes * Add correct address range * Fix check type for Device Id * Tweak gpu e2e test params * Get rid of additional net in PE params * Add gpu vendor params * Add gpu params to e2e config * Drop assign and check of unsued variables * Drop assign and check of unsued variables
…ix-cloud-native#622) Remove the template comment from the bootstrap data to ensure hostname directly in the bootstrap data instead of templated string.
…ud-native#618) * fix: removing subnet.ClusterReference from GetSubnetUUID
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @cloud-team-rebase-bot[bot]. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
* Revert "NCN-109324: enforce NutanixMachine and NutanixFailureDomain spec field "subnets" not have duplicates (nutanix-cloud-native#560)" This reverts commit b7a3a26. * Revert "NCN-108631: Enforce CEL validation on NutanixResourceIdentifier (nutanix-cloud-native#549)" This reverts commit cfd7cff.
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-main
branch
2 times, most recently
from
7a373c6 to
af34748
Compare
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-main
branch
from
af34748 to
40e8ed5
Compare
…native#632) The subnet filtering logic was only checking ClusterReference field, which caused subnets without this field to be incorrectly filtered out. According to the networking team, non-overlay subnets can have: - Both ClusterReference and ClusterReferenceList (most cases) - Only ClusterReference (old AOS clusters <= 7.0) - Only ClusterReferenceList (PC-based vSwitches >= 7.3) This fix adds a new subnetBelongsToCluster helper function that checks both fields, ensuring subnets are correctly matched regardless of which field(s) are populated. Changes: - Add subnetBelongsToCluster() helper to check both ClusterReference and ClusterReferenceList fields - Update GetSubnetUUID() to use the new helper function - Add comprehensive unit tests covering all scenarios
cloud-team-rebase-bot
bot
changed the title
cloud-team-bot
bot
force-pushed
the
rebase-bot-main
branch
2 times, most recently
from
78d4b19 to
94396ce
Compare
cloud-team-bot
bot
force-pushed
the
rebase-bot-main
branch
2 times, most recently
from
cf6406f to
3cae68f
Compare
cloud-team-bot
bot
force-pushed
the
rebase-bot-main
branch
from
3cae68f to
3218aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.