🌱 OCPBUGS-119951: UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI

[stefanonardo]

Summary

• Deletes 14 upstream .github/ workflow and issue template files that have no use in the OpenShift downstream fork
• Neuters the trigger of pr-golangci-lint.yaml instead of deleting it, because the root Makefile extracts GOLANGCI_LINT_VER from this file
• Fixes the actively failing "PR golangci-lint / lint (pull_request)" job on every PR (https://github.com/openshift/cluster-api-provider-aws/actions/runs/33621439331/job/100219125178)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores

  • Removed automated AMI listing, building, publishing, and cleanup workflows.
  • Removed Kubernetes release detection and automated AMI update pull requests.
  • Removed pull request verification, approval automation, link checking, security scanning, and release workflows.
  • Pull request linting is now run manually instead of automatically.

• Documentation

  • Removed maintainer-change and reviewer-change issue templates.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1240723d-78f5-4e38-afbf-39360396687c

📥 Commits

Reviewing files that changed from the base of the PR and between e345a83 and 74c30b8.

📒 Files selected for processing (15)

• .github/ISSUE_TEMPLATE/maintainer_change.yml
• .github/ISSUE_TEMPLATE/reviewer_change.yml
• .github/workflows/ami-housekeeping-delete.yml
• .github/workflows/ami-housekeeping-list.yml
• .github/workflows/auto-publish-ami.yml
• .github/workflows/build-ami-v2.yml
• .github/workflows/build-ami-varsfile.yml
• .github/workflows/build-ami.yml
• .github/workflows/detect-k8s-releases.yml
• .github/workflows/md-link-checker.yml
• .github/workflows/pr-gh-workflow-approve.yaml
• .github/workflows/pr-golangci-lint.yaml
• .github/workflows/pr-verify.yml
• .github/workflows/release.yaml
• .github/workflows/scan.yml

💤 Files with no reviewable changes (14)

• .github/workflows/pr-gh-workflow-approve.yaml
• .github/workflows/ami-housekeeping-list.yml
• .github/ISSUE_TEMPLATE/reviewer_change.yml
• .github/workflows/build-ami.yml
• .github/ISSUE_TEMPLATE/maintainer_change.yml
• .github/workflows/md-link-checker.yml
• .github/workflows/detect-k8s-releases.yml
• .github/workflows/ami-housekeeping-delete.yml
• .github/workflows/pr-verify.yml
• .github/workflows/scan.yml
• .github/workflows/build-ami-varsfile.yml
• .github/workflows/build-ami-v2.yml
• .github/workflows/release.yaml
• .github/workflows/auto-publish-ami.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The PR removes maintainer and reviewer issue templates and most GitHub Actions workflows. It changes golangci-lint from automatic pull request execution to manual dispatch. Removed workflows include AMI, release, scanning, verification, link-checking, and approval automation.

Changes

GitHub automation

Layer / File(s)	Summary
Issue template and workflow removal .github/ISSUE_TEMPLATE/*, .github/workflows/ami-*, .github/workflows/auto-publish-ami.yml, .github/workflows/build-ami*.yml, .github/workflows/detect-k8s-releases.yml, .github/workflows/md-link-checker.yml, .github/workflows/pr-gh-workflow-approve.yaml, .github/workflows/pr-verify.yml, .github/workflows/release.yaml, .github/workflows/scan.yml	The maintainer and reviewer issue templates and the listed GitHub Actions workflows were deleted.
Manual golangci-lint execution .github/workflows/pr-golangci-lint.yaml	The workflow trigger changed from pull request events to workflow_dispatch.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 74c30

The PR removes unused upstream CI and issue-template files while preserving the lint version source and disabling the failing lint trigger; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes only .github YAML files. The exact diff contains no Ginkgo test files and no It, Describe, Context, or When title changes. Therefore, it introduces no unstable or ov…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only 15 .github issue-template/workflow files. The parent-to-HEAD diff contains no Go test, Ginkgo, or other test-structure changes. Therefore the stated Ginkgo test q…
Microshift Test Compatibility	✅ Passed	The pull request changes only GitHub issue templates and workflow files. The first-parent diff contains no added or modified Go test files and no new Ginkgo test declarations. Therefore, the MicroShif…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The custom check is not applicable. The pull request adds no Ginkgo e2e tests or other test declarations. The actual diff only deletes GitHub workflow and issue-template files and changes `pr-golangci…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only .github/ issue templates and GitHub Actions workflows. The only modified file changes pr-golangci-lint.yaml from pull_request to workflow_dispatch; it adds …
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes only .github YAML files. The exact patch contains no changed Go or test source files, and its only added line is workflow_dispatch: {} in pr-golangci-lint.yaml. It…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests and no test networking code. The commit only deletes .github templates/workflows and changes pr-golangci-lint.yaml to manual triggering. Therefore, …
No-Weak-Crypto	✅ Passed	PASS: The pull request adds only workflow_dispatch: {} to .github/workflows/pr-golangci-lint.yaml and deletes unrelated workflow/template files. The introduced content contains no MD5, SHA1, DES, …
Container-Privileges	✅ Passed	PASS: The committed patch changes only GitHub issue templates and GitHub Actions workflows. It adds no container or Kubernetes manifest. The only retained-file change replaces the pull-request trigger…
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive-data logging was introduced. The pull-request diff contains only one added line, workflow_dispatch: {}, and deletes the other listed files. The retained echo writes only the Go versio…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: removing unused upstream .github files from OpenShift CI. The prefixes add context but do not make the title unclear.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

The pull request changes only .github YAML files. The exact diff contains no Ginkgo test files and no It, Describe, Context, or When title changes. Therefore, it introduces no unstable or overly specific test name.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only 15 .github issue-template/workflow files. The parent-to-HEAD diff contains no Go test, Ginkgo, or other test-structure changes. Therefore the stated Ginkgo test quality requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

The pull request changes only GitHub issue templates and workflow files. The first-parent diff contains no added or modified Go test files and no new Ginkgo test declarations. Therefore, the MicroShift test compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

The custom check is not applicable. The pull request adds no Ginkgo e2e tests or other test declarations. The actual diff only deletes GitHub workflow and issue-template files and changes pr-golangci-lint.yaml from pull_request to workflow_dispatch; no It(), Describe(), Context(), or When() additions are present.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only .github/ issue templates and GitHub Actions workflows. The only modified file changes pr-golangci-lint.yaml from pull_request to workflow_dispatch; it adds no deployment manifest, operator/controller code, or scheduling constraint. All other listed files are deleted. Therefore, the custom check is not applicable and no topology-incompatible scheduling behavior was introduced.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only .github YAML files. The exact patch contains no changed Go or test source files, and its only added line is workflow_dispatch: {} in pr-golangci-lint.yaml. It introduces no OTE binary code or process-level stdout write. Existing TestMain and Ginkgo references are unchanged and cannot cause a failure under the check's causality requirement.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests and no test networking code. The commit only deletes .github templates/workflows and changes pr-golangci-lint.yaml to manual triggering. Therefore, this IPv6 and disconnected-network test check is not applicable.

Full details: No-Weak-Crypto

Explanation

PASS: The pull request adds only workflow_dispatch: {} to .github/workflows/pr-golangci-lint.yaml and deletes unrelated workflow/template files. The introduced content contains no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison logic. Deletions do not introduce weak cryptography.

Full details: Container-Privileges

Explanation

PASS: The committed patch changes only GitHub issue templates and GitHub Actions workflows. It adds no container or Kubernetes manifest. The only retained-file change replaces the pull-request trigger with workflow_dispatch; no added line contains a listed privilege setting. The privilege-related diff content is limited to deleting a verify-container-images workflow step, so no explicit failure condition was introduced.

Full details: No-Sensitive-Data-In-Logs

Explanation

No sensitive-data logging was introduced. The pull-request diff contains only one added line, workflow_dispatch: {}, and deletes the other listed files. The retained echo writes only the Go version to $GITHUB_OUTPUT; it is unchanged from the base revision and does not expose passwords, tokens, API keys, PII, hostnames, or customer data.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[damdo]

/approve
/lgtm

/verified by ci

[openshift-ci-robot]

@damdo: This PR has been marked as verified by ci.

Details

In response to this:

/approve
/lgtm

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-capi-techpreview
/test e2e-aws-ovn
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/override ci/prow/e2e-aws-capi-techpreview ci/prow/e2e-aws-ovn ci/prow/e2e-aws-serial-1of2 ci/prow/e2e-aws-serial-2of2 ci/prow/e2e-hypershift

[damdo]

/skip

[openshift-ci]

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-capi-techpreview, ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-serial-1of2, ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-aws-capi-techpreview ci/prow/e2e-aws-ovn ci/prow/e2e-aws-serial-1of2 ci/prow/e2e-aws-serial-2of2 ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@stefanonardo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@stefanonardo: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Deletes 14 upstream .github/ workflow and issue template files that have no use in the OpenShift downstream fork
• Neuters the trigger of pr-golangci-lint.yaml instead of deleting it, because the root Makefile extracts GOLANGCI_LINT_VER from this file
• Fixes the actively failing "PR golangci-lint / lint (pull_request)" job on every PR (https://github.com/openshift/cluster-api-provider-aws/actions/runs/33621439331/job/100219125178)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores

• Removed automated AMI listing, building, publishing, and cleanup workflows.

• Removed Kubernetes release detection and automated AMI update pull requests.

• Removed pull request verification, approval automation, link checking, security scanning, and release workflows.

• Pull request linting is now run manually instead of automatically.

• Documentation

• Removed maintainer-change and reviewer-change issue templates.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stefanonardo]

/cherry-pick release-4.22 release-4.21

[openshift-cherrypick-robot]

@stefanonardo: #632 failed to apply on top of branch "release-4.22":

Applying: UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI
Using index info to reconstruct a base tree...
A	.github/workflows/ami-housekeeping-delete.yml
A	.github/workflows/ami-housekeeping-list.yml
A	.github/workflows/auto-publish-ami.yml
A	.github/workflows/build-ami-v2.yml
M	.github/workflows/build-ami-varsfile.yml
M	.github/workflows/build-ami.yml
A	.github/workflows/detect-k8s-releases.yml
M	.github/workflows/md-link-checker.yml
M	.github/workflows/pr-gh-workflow-approve.yaml
M	.github/workflows/pr-golangci-lint.yaml
M	.github/workflows/pr-verify.yml
M	.github/workflows/release.yaml
M	.github/workflows/scan.yml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): .github/workflows/build-ami-varsfile.yml deleted in UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI and modified in HEAD.  Version HEAD of .github/workflows/build-ami-varsfile.yml left in tree.
CONFLICT (modify/delete): .github/workflows/build-ami.yml deleted in UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI and modified in HEAD.  Version HEAD of .github/workflows/build-ami.yml left in tree.
CONFLICT (modify/delete): .github/workflows/md-link-checker.yml deleted in UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI and modified in HEAD.  Version HEAD of .github/workflows/md-link-checker.yml left in tree.
CONFLICT (modify/delete): .github/workflows/pr-gh-workflow-approve.yaml deleted in UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI and modified in HEAD.  Version HEAD of .github/workflows/pr-gh-workflow-approve.yaml left in tree.
Auto-merging .github/workflows/pr-golangci-lint.yaml
CONFLICT (modify/delete): .github/workflows/pr-verify.yml deleted in UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI and modified in HEAD.  Version HEAD of .github/workflows/pr-verify.yml left in tree.
CONFLICT (modify/delete): .github/workflows/release.yaml deleted in UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI and modified in HEAD.  Version HEAD of .github/workflows/release.yaml left in tree.
CONFLICT (modify/delete): .github/workflows/scan.yml deleted in UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI and modified in HEAD.  Version HEAD of .github/workflows/scan.yml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 UPSTREAM: <carry>: Remove upstream .github files unused in OpenShift CI

Details

In response to this:

/cherry-pick release-4.22 release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stefanonardo]

/cherry-pick release-5.0

[openshift-cherrypick-robot]

@stefanonardo: new pull request created: #634

Details

In response to this:

/cherry-pick release-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stefanonardo]

/jira refresh

[openshift-ci-robot]

@stefanonardo: Jira Issue Verification Checks: Jira Issue OCPBUGS-119951
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-119951 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

• Deletes 14 upstream .github/ workflow and issue template files that have no use in the OpenShift downstream fork
• Neuters the trigger of pr-golangci-lint.yaml instead of deleting it, because the root Makefile extracts GOLANGCI_LINT_VER from this file
• Fixes the actively failing "PR golangci-lint / lint (pull_request)" job on every PR (https://github.com/openshift/cluster-api-provider-aws/actions/runs/33621439331/job/100219125178)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores

• Removed automated AMI listing, building, publishing, and cleanup workflows.

• Removed Kubernetes release detection and automated AMI update pull requests.

• Removed pull request verification, approval automation, link checking, security scanning, and release workflows.

• Pull request linting is now run manually instead of automatically.

• Documentation

• Removed maintainer-change and reviewer-change issue templates.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stefanonardo: Jira Issue OCPBUGS-119951 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.