Skip to content

[release-4.12] 🐛 OCPBUGS-102101: replace golang.org/x/net with openshift-sustaining/net v0.35.0-sec.4 for CVE-2026-33814 - #631

Open
amitesh1201 wants to merge 2 commits into
openshift:release-4.12from
amitesh1201:fix/cve-2026-33814-release-4.12
Open

amitesh1201 wants to merge 2 commits into
openshift:release-4.12from
amitesh1201:fix/cve-2026-33814-release-4.12

Conversation

@amitesh1201

Copy link
Copy Markdown

Summary

  • CVE: CVE-2026-33814 — HTTP/2 DoS via malformed SETTINGS_MAX_FRAME_SIZE=0
  • Jira: https://issues.redhat.com/browse/OCPBUGS-102101
  • Package: golang.org/x/net → github.com/openshift-sustaining/net v0.35.0-sec.4
  • Risk: MEDIUM — http2 Transport via client-go; requires compromised API server

Go version constraint: upstream fix (>= v0.53.0) requires go 1.25; mitigated via backport fork replace.
Fix upstream: https://go.dev/cl/761640

Note: v0.35.0-sec.4 also includes CVE-2026-27136 html tokenization fix (https://go.dev/cl/781685).

Changes

  • go.mod + hack/tools/go.mod: replace directive for golang.org/x/net
  • go.sum + hack/tools/go.sum: updated checksums
  • vendor/golang.org/x/net/http2/: patched (plus transitive x/sys, x/crypto, x/text vendor refresh)

Test Plan

  • go build -mod=vendor ./... succeeds (Go 1.18)
  • grep "^go " go.mod unchanged (go 1.17)
  • make test passes

Made with Cursor

amitesh1201 and others added 2 commits September 2, 2026 19:18
…/net v0.35.0-sec.4

CVE-2026-33814: http2 DoS via SETTINGS_MAX_FRAME_SIZE=0
Signed-off-by: Amit Yadav <ayadav@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Amit Yadav <ayadav@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 32156c3d-1689-4305-9800-cfc5aaab42c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

Copy link
Copy Markdown

@amitesh1201: This pull request references Jira Issue OCPBUGS-102101, which is invalid:

  • expected dependent Jira Issue OCPBUGS-102293 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • CVE: CVE-2026-33814 — HTTP/2 DoS via malformed SETTINGS_MAX_FRAME_SIZE=0
  • Jira: https://issues.redhat.com/browse/OCPBUGS-102101
  • Package: golang.org/x/net → github.com/openshift-sustaining/net v0.35.0-sec.4
  • Risk: MEDIUM — http2 Transport via client-go; requires compromised API server

Go version constraint: upstream fix (>= v0.53.0) requires go 1.25; mitigated via backport fork replace.
Fix upstream: https://go.dev/cl/761640

Note: v0.35.0-sec.4 also includes CVE-2026-27136 html tokenization fix (https://go.dev/cl/781685).

Changes

  • go.mod + hack/tools/go.mod: replace directive for golang.org/x/net
  • go.sum + hack/tools/go.sum: updated checksums
  • vendor/golang.org/x/net/http2/: patched (plus transitive x/sys, x/crypto, x/text vendor refresh)

Test Plan

  • go build -mod=vendor ./... succeeds (Go 1.18)
  • grep "^go " go.mod unchanged (go 1.17)
  • make test passes

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from damdo and elmiko September 2, 2026 13:52
@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fedosin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo

damdo commented Sep 16, 2026

Copy link
Copy Markdown
Member

/retest

3 similar comments
@rissh

rissh commented Sep 21, 2026

Copy link
Copy Markdown

/retest

@rissh

rissh commented Sep 24, 2026

Copy link
Copy Markdown

/retest

@rissh

rissh commented Oct 9, 2026

Copy link
Copy Markdown

/retest

@openshift-ci

openshift-ci Bot commented Oct 9, 2026

Copy link
Copy Markdown

@amitesh1201: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 958b006 link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants