Skip to content

[release-4.21] 🐛 OCPBUGS-121766: UPSTREAM: <carry>: Fix unit tests for OpenShift CI environment - #628

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.21from
stefanonardo:fix/unit-test-release-4.21
Sep 9, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.21from
stefanonardo:fix/unit-test-release-4.21

Conversation

@stefanonardo

@stefanonardo stefanonardo commented Aug 21, 2026 •

Copy link
Copy Markdown

Cherry-picks from release-4.22:

  • 8e691fb8f UPSTREAM: : Fix unit tests for OpenShift CI environment
  • 141ba60df Fix flaky test TestROSARoleConfigReconcileExist

Test plan

  • Prow unit test job passes on this PR

@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • The storage.googleapis.com/kubebuilder-tools GCS bucket now returns HTTP 403, causing the Prow unit test job (pull-ci-openshift-cluster-api-provider-aws-release-4.21-unit) to fail before any tests run (curl exit code 22).
  • Replace openshift/unit-tests.sh with the approach already used on main: call make test-verbose, which uses the setup-envtest tool (already wired in the release-4.21 Makefile) to fetch test binaries via the GitHub-hosted envtest-releases.yaml index.
  • Delete openshift/fetch_ext_bins.sh — it only existed to serve the broken GCS download path.

Test plan

  • Prow unit test job passes on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bee403d6-c700-440f-949a-8c9b01be36b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from damdo and nrb August 21, 2026 12:47
@stefanonardo
stefanonardo force-pushed the fix/unit-test-release-4.21 branch from a905c12 to fbc7ac8 Compare August 21, 2026 12:55
@stefanonardo stefanonardo changed the title NO-JIRA: fix unit tests by replacing deprecated kubebuilder-tools GCS download UPSTREAM: <carry>: openshift: fix unit tests by replacing deprecated kubebuilder-tools GCS download Aug 21, 2026
@stefanonardo stefanonardo changed the title UPSTREAM: <carry>: openshift: fix unit tests by replacing deprecated kubebuilder-tools GCS download [release-4.21] 🐛 UPSTREAM: <carry>: openshift: fix unit tests by replacing deprecated kubebuilder-tools GCS download Aug 21, 2026
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

  • The storage.googleapis.com/kubebuilder-tools GCS bucket now returns HTTP 403, causing the Prow unit test job (pull-ci-openshift-cluster-api-provider-aws-release-4.21-unit) to fail before any tests run (curl exit code 22).
  • Replace openshift/unit-tests.sh with the approach already used on main: call make test-verbose, which uses the setup-envtest tool (already wired in the release-4.21 Makefile) to fetch test binaries via the GitHub-hosted envtest-releases.yaml index.
  • Delete openshift/fetch_ext_bins.sh — it only existed to serve the broken GCS download path.

Test plan

  • Prow unit test job passes on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo stefanonardo changed the title [release-4.21] 🐛 UPSTREAM: <carry>: openshift: fix unit tests by replacing deprecated kubebuilder-tools GCS download [release-4.21] 🐛 NO-JIRA: UPSTREAM: <carry>: openshift: fix unit tests by replacing deprecated kubebuilder-tools GCS download Aug 21, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • The storage.googleapis.com/kubebuilder-tools GCS bucket now returns HTTP 403, causing the Prow unit test job (pull-ci-openshift-cluster-api-provider-aws-release-4.21-unit) to fail before any tests run (curl exit code 22).
  • Replace openshift/unit-tests.sh with the approach already used on main: call make test-verbose, which uses the setup-envtest tool (already wired in the release-4.21 Makefile) to fetch test binaries via the GitHub-hosted envtest-releases.yaml index.
  • Delete openshift/fetch_ext_bins.sh — it only existed to serve the broken GCS download path.

Test plan

  • Prow unit test job passes on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: This pull request explicitly references no jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo
stefanonardo force-pushed the fix/unit-test-release-4.21 branch 2 times, most recently from 6962670 to 8fe9013 Compare August 24, 2026 08:20
@stefanonardo
stefanonardo force-pushed the fix/unit-test-release-4.21 branch from 8fe9013 to 67886d1 Compare September 2, 2026 09:56
@stefanonardo stefanonardo changed the title [release-4.21] 🐛 NO-JIRA: UPSTREAM: <carry>: openshift: fix unit tests by replacing deprecated kubebuilder-tools GCS download [release-4.21] 🐛 NO-JIRA: UPSTREAM: <carry>: Fix unit tests for OpenShift CI environment Sep 2, 2026
@stefanonardo
stefanonardo force-pushed the fix/unit-test-release-4.21 branch from 67886d1 to 61bbc57 Compare September 2, 2026 10:49

@damdo damdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2026
@stefanonardo
stefanonardo force-pushed the fix/unit-test-release-4.21 branch 2 times, most recently from 4b67da1 to c5a9d19 Compare September 3, 2026 08:06
@stefanonardo
stefanonardo force-pushed the fix/unit-test-release-4.21 branch from c5a9d19 to 10ceef5 Compare September 3, 2026 08:07
@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2026
@stefanonardo stefanonardo reopened this Sep 3, 2026
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2026
@openshift-ci

openshift-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-serial-1of2, ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-aws-ovn ci/prow/e2e-aws-serial-1of2 ci/prow/e2e-aws-serial-2of2 ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo

damdo commented Sep 4, 2026

Copy link
Copy Markdown
Member

/test e2e-aws-capi-techpreview

@damdo damdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

/label backport-risk-assessed

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@damdo: This PR has been marked as verified by ci.

Details

In response to this:

/approve
/lgtm

/label backport-risk-assessed

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2026
@openshift-merge-bot

Copy link
Copy Markdown

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-capi-techpreview
/test e2e-aws-ovn
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-hypershift

@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 7, 2026
@damdo

damdo commented Sep 7, 2026

Copy link
Copy Markdown
Member

/retest

1 similar comment
@damdo

damdo commented Sep 8, 2026

Copy link
Copy Markdown
Member

/retest

@damdo

damdo commented Sep 8, 2026

Copy link
Copy Markdown
Member

The hypershift failure is unrelated as this is a pure unit test change

/override ci/prow/e2e-hypershift

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-hypershift

Details

In response to this:

The hypershift failure is unrelated as this is a pure unit test change

/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown

@stefanonardo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift c3a7174 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stefanonardo

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: This pull request explicitly references no jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo stefanonardo changed the title [release-4.21] 🐛 NO-JIRA: UPSTREAM: <carry>: Fix unit tests for OpenShift CI environment [release-4.21] 🐛 OCPBUGS-121766: UPSTREAM: <carry>: Fix unit tests for OpenShift CI environment Sep 8, 2026
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: This pull request references Jira Issue OCPBUGS-121766, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-121766 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherry-picks from release-4.22:

  • 8e691fb8f UPSTREAM: : Fix unit tests for OpenShift CI environment
  • 141ba60df Fix flaky test TestROSARoleConfigReconcileExist

Test plan

  • Prow unit test job passes on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: This pull request references Jira Issue OCPBUGS-121766, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-121766 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 9, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: This pull request references Jira Issue OCPBUGS-121766, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-122021 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-122021 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit a308e12 into openshift:release-4.21 Sep 9, 2026
13 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@stefanonardo: Jira Issue Verification Checks: Jira Issue OCPBUGS-121766
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-121766 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Cherry-picks from release-4.22:

  • 8e691fb8f UPSTREAM: : Fix unit tests for OpenShift CI environment
  • 141ba60df Fix flaky test TestROSARoleConfigReconcileExist

Test plan

  • Prow unit test job passes on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stefanonardo

Copy link
Copy Markdown
Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

Copy link
Copy Markdown

@stefanonardo: #628 failed to apply on top of branch "release-4.20":

Applying: UPSTREAM: <carry>: Fix unit tests for OpenShift CI environment
Applying: UPSTREAM: <carry>: Fix flaky test TestROSARoleConfigReconcileExist
Using index info to reconstruct a base tree...
M	exp/controllers/rosaroleconfig_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging exp/controllers/rosaroleconfig_controller_test.go
CONFLICT (content): Merge conflict in exp/controllers/rosaroleconfig_controller_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 UPSTREAM: <carry>: Fix flaky test TestROSARoleConfigReconcileExist

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants