NO-JIRA: remove beta enabled TranslateStreamCloseWebsocketRequests feature from gates #2613

geoberle · 2025-12-04T13:42:14Z

the TranslateStreamCloseWebsocketRequests feature is beta enabled in 1.30

https://github.com/openshift/kubernetes/blob/0987ea121e432412b7582943a195708e67e0a38f/pkg/features/kube_features.go#L1828-L1831

openshift-ci-robot · 2025-12-04T13:42:17Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2025-12-04T13:42:19Z

@geoberle: This pull request explicitly references no jira issue.

In response to this:

the TranslateStreamCloseWebsocketRequests feature is beta enabled in 1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-12-04T13:42:32Z

Walkthrough

Removed the TranslateStreamCloseWebsocketRequests feature gate from documentation, its Go declaration, and from multiple feature-gate manifest files for Hypershift and SelfManagedHA configurations.

Changes

Cohort / File(s)	Summary
Documentation `features.md`	Deleted the `TranslateStreamCloseWebsocketRequests` row from the features table.
Feature gate code `features/features.go`	Removed the `FeatureGateTranslateStreamCloseWebsocketRequests` public declaration and its registration from `allFeatureGates`.
Hypershift manifests `payload-manifests/featuregates/featureGate-Hypershift-Default.yaml`, `payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml`, `payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml`	Removed `TranslateStreamCloseWebsocketRequests` from disabled/enabled lists in the three Hypershift feature-gate manifests.
SelfManagedHA manifests `payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml`, `payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml`, `payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml`	Removed `TranslateStreamCloseWebsocketRequests` from disabled/enabled lists in the three SelfManagedHA feature-gate manifests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Check for any remaining references to TranslateStreamCloseWebsocketRequests elsewhere (imports, tests, docs).
Verify removal in features/features.go doesn't break build (unused imports or references).
Validate YAML manifests remain syntactically correct and consistent after deletions.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e8c6c8e and 887fcda.

📒 Files selected for processing (8)

features.md (0 hunks)
features/features.go (0 hunks)
payload-manifests/featuregates/featureGate-Hypershift-Default.yaml (0 hunks)
payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml (0 hunks)
payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml (0 hunks)
payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml (0 hunks)
payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml (0 hunks)
payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml (0 hunks)

💤 Files with no reviewable changes (8)

payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
features.md
payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
features/features.go
payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2025-12-04T13:42:52Z

Hello @geoberle! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

tkashem · 2025-12-04T14:07:05Z

/lgtm

JoelSpeed · 2025-12-04T14:08:54Z

/lgtm

/label acknowledge-critical-fixes-only

openshift-ci-robot · 2025-12-04T14:11:18Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

JoelSpeed · 2025-12-05T14:59:30Z

/retest-required

…ature from gates the `TranslateStreamCloseWebsocketRequests` feature is beta enabled in 1.30 Signed-off-by: Gerd Oberlechner <[email protected]>

JoelSpeed · 2025-12-09T10:44:08Z

/lgtm

openshift-ci-robot · 2025-12-09T10:44:49Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

openshift-ci · 2025-12-09T10:44:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

geoberle · 2025-12-10T11:33:21Z

/test e2e-upgrade

geoberle · 2025-12-11T07:34:55Z

/retest-required

JoelSpeed · 2025-12-11T14:32:09Z

@geoberle Have you been able to test that this behaves as you're expecting? We need to add the verified label for this to merge and for that we are expecting someone has manually tested this

geoberle · 2025-12-12T12:00:58Z

@JoelSpeed yes i was able to create a cluster based on this PR and test real websocket connections

oc debug node/xyz -v=8
│ I1212 12:57:44.099321   60584 round_trippers.go:470] GET https://api.ci-ln-xyz.gcp-2.ci.openshift.org:6443/api/v1/namespaces/default/pods/ci-ln-xyz-2sznd-debug-l4b2g/attach?container=container-00&stdin=true&stdout=true&tty=true                                            │
│ I1212 12:57:44.099353   60584 round_trippers.go:476] Request Headers:                                                                                                                                                                                                                                             │
│ I1212 12:57:44.099367   60584 round_trippers.go:480]     User-Agent: oc/4.19.10 (darwin/arm64) kubernetes/298429b                                                                                                                                                                                                 │
│ I1212 12:57:44.099374   60584 round_trippers.go:480]     Sec-Websocket-Protocol: v5.channel.k8s.io                                                                                                                                                                                                                │
│ I1212 12:57:44.400641   60584 round_trippers.go:581] Response Status: 101 Switching Protocols in 301 milliseconds                                                                                                                                                                                                 │
│ I1212 12:57:44.400694   60584 round_trippers.go:584] Response Headers:                                                                                                                                                                                                                                            │
│ I1212 12:57:44.400715   60584 round_trippers.go:587]     Sec-Websocket-Protocol: v5.channel.k8s.io                                                                                                                                                                                                                │
│ I1212 12:57:44.400727   60584 round_trippers.go:587]     Upgrade: websocket                                                                                                                                                                                                                                       │
│ I1212 12:57:44.400737   60584 round_trippers.go:587]     Connection: Upgrade                                                                                                                                                                                                                                      │
│ I1212 12:57:44.400746   60584 round_trippers.go:587]     Sec-Websocket-Accept: vdigghDGu9gEQRqlJvL60cAeRfk=

previously without this PR this showed a failed websocket handshake and fallback to SPDY

geoberle · 2025-12-12T12:01:17Z

/retest-required

JoelSpeed · 2025-12-12T12:32:59Z

/verified by @geoberle

openshift-ci-robot · 2025-12-12T12:33:12Z

@JoelSpeed: This PR has been marked as verified by @geoberle.

In response to this:

/verified by @geoberle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-12-12T15:05:44Z

/retest-required

Remaining retests: 0 against base HEAD c2a41ea and 2 for PR HEAD 887fcda in total

openshift-ci · 2025-12-12T17:09:53Z

@geoberle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2025

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 4, 2025

openshift-ci bot requested review from JoelSpeed and everettraven December 4, 2025 13:47

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 4, 2025

openshift-ci bot assigned tkashem Dec 4, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025

openshift-ci bot assigned JoelSpeed Dec 4, 2025

NO-JIRA: remove beta enabled TranslateStreamCloseWebsocketRequests fe…

887fcda

…ature from gates the `TranslateStreamCloseWebsocketRequests` feature is beta enabled in 1.30 Signed-off-by: Gerd Oberlechner <[email protected]>

geoberle force-pushed the drop-TranslateStreamCloseWebsocketRequests-gate branch from e8c6c8e to 887fcda Compare December 9, 2025 10:29

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 12, 2025

openshift-merge-bot bot merged commit cafbd60 into openshift:master Dec 12, 2025
28 checks passed

NO-JIRA: remove beta enabled TranslateStreamCloseWebsocketRequests feature from gates #2613

NO-JIRA: remove beta enabled TranslateStreamCloseWebsocketRequests feature from gates #2613

Conversation

geoberle commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

coderabbitai bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Dec 4, 2025

Uh oh!

tkashem commented Dec 4, 2025

Uh oh!

JoelSpeed commented Dec 4, 2025

Uh oh!

openshift-ci-robot commented Dec 4, 2025

Uh oh!

JoelSpeed commented Dec 5, 2025

Uh oh!

JoelSpeed commented Dec 9, 2025

Uh oh!

openshift-ci-robot commented Dec 9, 2025

Uh oh!

openshift-ci bot commented Dec 9, 2025

Uh oh!

geoberle commented Dec 10, 2025

Uh oh!

geoberle commented Dec 11, 2025

Uh oh!

JoelSpeed commented Dec 11, 2025

Uh oh!

geoberle commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geoberle commented Dec 12, 2025

Uh oh!

JoelSpeed commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

openshift-ci bot commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

geoberle commented Dec 4, 2025 •

edited

Loading

coderabbitai bot commented Dec 4, 2025 •

edited

Loading

geoberle commented Dec 12, 2025 •

edited

Loading