Skip to content

Conversation

richardsonnick
Copy link

To support new option set default ssl curves.
Adds an option to TLSProfile config to add a list of supported groups.

See for more context openshift/cluster-ingress-operator#1287

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

Hello @richardsonnick! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2025
@everettraven
Copy link
Contributor

/assign

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a handful of comments.

Additionally, this is a change to a v1 API and requires that the new field is introduced behind a new feature gate.

That means there will need to be an enhancement proposal written that includes how components are expected to behave with this change, changes that need to be made, and a plan for how the changes will be tested.

Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from everettraven. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardsonnick
Copy link
Author

Additionally, this is a change to a v1 API and requires that the new field is introduced behind a new feature gate.

Sorry for the over sight on this, first time contributing. I'll circle back with a more in depths review of this change.

Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@richardsonnick: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 93fe07b link true /test verify
ci/prow/lint 93fe07b link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants