-
Notifications
You must be signed in to change notification settings - Fork 572
Add: Support for specifying elliptic curves in TLS handshake #2512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hello @richardsonnick! Some important instructions when contributing to openshift/api: |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a handful of comments.
Additionally, this is a change to a v1 API and requires that the new field is introduced behind a new feature gate.
That means there will need to be an enhancement proposal written that includes how components are expected to behave with this change, changes that need to be made, and a plan for how the changes will be tested.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Bryce Palmer <[email protected]>
Sorry for the over sight on this, first time contributing. I'll circle back with a more in depths review of this change. |
@richardsonnick: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
To support new option set default ssl curves.
Adds an option to TLSProfile config to add a list of supported groups.
See for more context openshift/cluster-ingress-operator#1287