Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAI example config and fix typo #56

Closed
wants to merge 2 commits into from

Conversation

panpan0000
Copy link

  • feat: add openAI format example CONFIG file

@panpan0000
Copy link
Author

/ping

@dagrayvid
Copy link
Collaborator

Thank you @panpan0000 for the PR and sorry for the delayed response.

Could you please rename the config-openai.yaml to config.yaml, and move the config-tgis.yaml to a new directory called example-configs?

We may have other plugins later that we can add to example configs.

We have also discussed the possibility of allowing some inheritance/extension logic for configs to enable users to have a base config and then sub-configs to only override specific fields, so there may be more changes coming along these lines.

   * feat: add openAI format example CONFIG file
@panpan0000
Copy link
Author

Sorry for late, @dagrayvid , just fixed

@panpan0000 panpan0000 force-pushed the main branch 4 times, most recently from f7b10ad to 0315e5d Compare January 3, 2025 10:58
@dagrayvid
Copy link
Collaborator

@panpan0000 Thanks again for the PR. We have switched the default config.yaml to the OpenAI plugin, and just merged a PR to add the ability to use an auth token / api key. The README fix and example tgis config.yaml is still a welcome addition. Could you rebase the PR if you still want to add these?

@panpan0000
Copy link
Author

Great. thanks to provide those!
I will close my PR :-)

@panpan0000 panpan0000 closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants