Skip to content

[WIP] AGENT-1193: Allow openshift-appliance to work with ephemeral payload #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rwsu
Copy link
Contributor

@rwsu rwsu commented May 13, 2025

Re-enable 04_agent_prepare_release.sh with ISO_NO_REGISTRY so that images can be built and placed in the ephemeral release payload and can then be consumed by OpenShift Appliance.

bfournie and others added 2 commits May 7, 2025 21:30
Use version v2 of oc-mirror. This version has many improvements over v1
but the primary reason for using v2 is that it allows nightly or CI
builds to be tested via the release field in the ImageSetConfiguration.

Note that oc-mirror is not currently used in any CI tests and has strictly
been used for local testing with the agent-based installer. As a
result its not necessary to keep backwards compatibility with v1.

It's expected that oc-mirror will eventually be used for setting up a
mirror for disconnected testing instead of 'oc adm release mirror'
since its the most common way to set up mirrors by our customers;
'oc adm release mirror' does not provide for installing additional
operators.
Re-enable 04_agent_prepare_release.sh with ISO_NO_REGISTRY
so that images can be built and placed in the ephemeral release
payload and can then be consumed by OpenShift Appliance.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2025
@openshift-ci openshift-ci bot requested review from bfournie and derekhiggins May 13, 2025 21:47
Copy link

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented May 14, 2025

@rwsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 a1c4b25 link true /test e2e-agent-compact-ipv4
ci/prow/e2e-metal-ipi-serial-ipv4 a1c4b25 link true /test e2e-metal-ipi-serial-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants