Don't restart NetworkManager unnecessarily #1762
Conversation
Restarting NM breaks VPN connections, which are required to build images for some OpenShift projects, notably machine-config-operator. Forcing a NetworkManager restart every time we update the node, even when no changes to the NetworkManager package were made, causes problems when working on patches to MCO. This change checks the NM version before and after the dnf update and only restarts NM if the version changed.
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required Error in ansible, nothing to do with this patch. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm I no longer remember why we even restart it... |
openshift-merge-bot
bot
merged commit 55b52c0
into
openshift-metal3:master
Restarting NM breaks VPN connections, which are required to build images for some OpenShift projects, notably machine-config-operator. Forcing a NetworkManager restart every time we update the node, even when no changes to the NetworkManager package were made, causes problems when working on patches to MCO.
This change checks the NM version before and after the dnf update and only restarts NM if the version changed.