OCPBUGS-55386: Update oc-mirror to use -v2 #1752
Conversation
Use version v2 of oc-mirror. This version has many improvements over v1 but the primary reason for using v2 is that it allows nightly or CI builds to be tested via the release field in the ImageSetConfiguration. Note that oc-mirror is not currently used in any CI tests and has strictly been used for local testing with the agent-based installer. As a result its not necessary to keep backwards compatibility with v1. It's expected that oc-mirror will eventually be used for setting up a mirror for disconnected testing instead of 'oc adm release mirror' since its the most common way to set up mirrors by our customers; 'oc adm release mirror' does not provide for installing additional operators.
|
/lgtm |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit fba144f
into
openshift-metal3:master
Use version v2 of oc-mirror. This version has many improvements over v1 but the primary reason for using v2 is that it allows nightly or CI builds to be tested via the release field in the ImageSetConfiguration.
Note that oc-mirror is not currently used in any CI tests and has strictly been used for local testing with the agent-based installer. As a result its not necessary to keep backwards compatibility with v1.
It's expected that oc-mirror will eventually be used for setting up a mirror for disconnected testing instead of 'oc adm release mirror' since its the most common way to set up mirrors by our customers; 'oc adm release mirror' does not provide for installing additional operators.