OCPEDGE-1825: [TNF] Reworked TNF logic to render fencing block conditionally. #1751
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Hi @jaypoulz. Thanks for your PR. I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jaypoulz
force-pushed
the
OCPEDGE-1749-tnf-fencing
branch
from
c3b0582 to
ae81aba
Compare
jaypoulz
force-pushed
the
OCPEDGE-1749-tnf-fencing
branch
3 times, most recently
from
9c1ec4c to
25dfa10
Compare
jaypoulz
changed the title
jaypoulz
force-pushed
the
OCPEDGE-1749-tnf-fencing
branch
from
25dfa10 to
fad6268
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
jaypoulz
force-pushed
the
OCPEDGE-1749-tnf-fencing
branch
from
fad6268 to
6431c84
Compare
jaypoulz
force-pushed
the
OCPEDGE-1749-tnf-fencing
branch
2 times, most recently
from
ed26ae7 to
9976402
Compare
|
/retest |
02_configure_host.sh
Outdated
| ansible-playbook \ | ||
| -e @vm_setup_vars.yml \ | ||
| -e "ironic_prefix=${CLUSTER_NAME}_" \ | ||
| -e "${ironic_prefix_env_var}" \ |
There was a problem hiding this comment.
This might have problematic implications. Since I've added this line, my clusters don't see to get past the ironic inspection phase. I'm wondering if the ostest_ is used somewhere else to identify the nodes somehow.
There was a problem hiding this comment.
I decided to avoid messing with the ironic name, since it's also used in the creation of the network bonds. Instead, I just reference the MASTER_HOSTNAME_FORMAT variable in the creation of the secret, which should align the secret name.
jaypoulz
force-pushed
the
OCPEDGE-1749-tnf-fencing
branch
from
9976402 to
e173077
Compare
…ionally. Two Node OpenShift with Fencing (TNF) is a deployment topology with two control-plane nodes that was introduce as a Dev Preview in OpenShift 4.19. This commit updates the logic around TNF to only render fencing credentials in releases 4.19 and up, and also the sslInsecure parameter so that it uses certificateVerification in 4.20 and up, as introduced in openshift/installer#9640.
jaypoulz
force-pushed
the
OCPEDGE-1749-tnf-fencing
branch
from
e173077 to
82ee019
Compare
|
tested successfully :) /lgtm |
|
@slintes: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
| done | ||
| } | ||
|
|
||
| function node_map_to_install_config_fencing_credentials() { |
There was a problem hiding this comment.
Side note: this should be moved outside of utils.sh to some more specific file.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 84682f1
into
openshift-metal3:master
Two Node OpenShift with Fencing (TNF) is a deployment topology with two control-plane nodes that was introduce as a Dev Preview in OpenShift 4.19. This commit updates the logic around TNF to only render fencing credentials in releases 4.19 and up, and also the sslInsecure parameter so that it uses certificateVerification in 4.20 and up, as introduced in openshift/installer#9640.