Skip to content

OCPEDGE-1825: [TNF] Reworked TNF logic to render fencing block conditionally. #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaypoulz
Copy link

@jaypoulz jaypoulz commented Apr 22, 2025

Two Node OpenShift with Fencing (TNF) is a deployment topology with two control-plane nodes that was introduce as a Dev Preview in OpenShift 4.19. This commit updates the logic around TNF to only render fencing credentials in releases 4.19 and up, and also the sslInsecure parameter so that it uses certificateVerification in 4.20 and up, as introduced in openshift/installer#9640.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2025
Copy link

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 22, 2025
Copy link

openshift-ci bot commented Apr 22, 2025

Hi @jaypoulz. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…ionally.

Two Node OpenShift with Fencing (TNF) is a deployment topology with two
control-plane nodes that was introduce as a Dev Preview in OpenShift
4.19. This commit updates the logic around TNF to only render fencing
credentials in releases 4.19 and up, and also the sslInsecure parameter
so that it uses certificateVerification in 4.20 and up, as introduced
in openshift/installer#9640.
@jaypoulz jaypoulz force-pushed the OCPEDGE-1749-tnf-fencing branch from 9c1ec4c to 25dfa10 Compare April 22, 2025 13:10
@jaypoulz jaypoulz changed the title OCPEDGE-1749: [TNF] Reworked TNF logic to render fencing block conditionally. OCPEDGE-1825: [TNF] Reworked TNF logic to render fencing block conditionally. Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant