Fix Assisted Service cleanup script #1476
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes the script responsible for cleaning up the Assisted Service deployment. It previously relied on the variable `NODES_PLATFORM` that has a value of `libvirt` and is unrelated to how the Assisted Service is deployed. With this change the Make target `assisted_deployment_cleanup` works correctly again. This PR changes the generic `clean` target as Assisted cleanup is redundant at this point as underlying OCP cluster has already been deleted.
|
/lgtm Looks like some sort of infra failure on all the jobs. |
|
/retest |
openshift-merge-robot
added
the
needs-rebase
|
@mkowalski: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mkowalski this looks stuck, you want to try and rebase it or we can close it? |
This PR fixes the script responsible for cleaning up the Assisted
Service deployment. It previously relied on the variable
NODES_PLATFORMthat has a value oflibvirtand is unrelatedto how the Assisted Service is deployed. With this change the
Make target
assisted_deployment_cleanupworks correctly again.This PR changes the generic
cleantarget as Assisted cleanup isredundant at this point as underlying OCP cluster has already been
deleted.