serial: rewrite test 47674 #1196
Open
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
Merged
shajmakh
force-pushed
the
replace-47674
branch
from
623dc17 to
26d560f
Compare
ffromani
reviewed
Feb 28, 2025
shajmakh
force-pushed
the
replace-47674
branch
2 times, most recently
from
8038f95 to
27991b1
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The test fails on <4.18, skip running it until the bug is fixed. |
openshift-ci
bot
removed
the
do-not-merge/hold
The previous version was fragile and maintained several times already. This fact means that the test should be rewritten and once the known bugs are fixed, new tests will be added to cover the e2e full scenario. The test goal is to verify that adjustments to NROP CR are done as expected and reflected in the RTE daemonsets. Previously, this was done via creating a new MCP for the test and associating to it one of the worker nodes that were part of the initial NROP node groups. This was causing a reboot when running on a cluster that is: a. < 4.18 or b. >= 4.18 and has the custom RTE selinux policy enabled In the new version of the test, we keep checking the same functionality while completely avoiding reboot. That is acheived by creating the new MCP, keeping it empty (no nodes are associated to it) and appending it as a second node group's selector. Then checks on the daemonsets are performed and the only cleanup would be deleting the test mcp. We keep the old version still because the new one will be skipped from running on < 4.18 due to https://issues.redhat.com/browse/OCPBUGS-52958. Once that is fixed, we should settle to the new version only. Signed-off-by: Shereen Haj <[email protected]>
|
/retest |
|
@shajmakh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was fragile and maintained several times already.
This fact means that the test should be rewritten and once the known bugs
are fixed, new tests will be added to cover the e2e full scenario.
The test goal is to verify that adjustments to NROP CR are done as
expected and reflected in the RTE daemonsets. Previously, this was done
via creating a new MCP for the test and associating to it one of the
worker nodes that were part of the initial NROP node groups. This was
causing a reboot when running on a cluster that is:
a. < 4.18 or
b. >= 4.18 and has the custom RTE selinux policy enabled
In the new version of the test, we keep checking the same functionality
while completely avoiding reboot. That is acheived by creating the new MCP,
keeping it empty (no nodes are associated to it) and appending it as a
second node group's selector. Then checks on the daemonsets are
performed and the only cleanup would be deleting the test mcp.