Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghactions: use kubectl instead of oc #1161

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Tal-or
Copy link
Collaborator

@Tal-or Tal-or commented Jan 23, 2025

oc binary seems to missing under the runner:
https://github.com/openshift-kni/numaresources-operator/actions/runs/12930090387/job/36060828252\?pr\=1155

It probably removed in one of the vm's distro update. Let's use kubectl instead.

oc binary seems to missing under the runner:
https://github.com/openshift-kni/numaresources-operator/actions/runs/12930090387/job/36060828252\?pr\=1155

It probably removed in one of the vm's distro update.
Let's use kubectl instead.

Signed-off-by: Talor Itzhak <[email protected]>
@Tal-or Tal-or requested a review from ffromani January 23, 2025 13:31
@openshift-ci openshift-ci bot requested a review from swatisehgal January 23, 2025 13:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

This is a RH-ism we introduced by mistake. We should always have used kubectl

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 192c636 into openshift-kni:main Jan 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants