project: kubebuilder layout v3 -> v4 #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
expected to fail in multiple lanes |
openshift-ci
bot
added
the
approved
ffromani
force-pushed
the
project-migrate-v3-to-v4
branch
2 times, most recently
from
118b628 to
120a3b5
Compare
|
should not be horribly broken anymore |
ffromani
force-pushed
the
project-migrate-v3-to-v4
branch
6 times, most recently
from
43aae27 to
d206124
Compare
|
/retest-required |
ffromani
force-pushed
the
project-migrate-v3-to-v4
branch
3 times, most recently
from
d2255a1 to
0ffa6aa
Compare
We have no good reason to get stuck on layout v3 and make our time harder when consuming upcoming changes and fixes. Most of the changes here stem from the fact we change the path of the API package. We also consume as much as possible from the new Makefile features. done using https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4 Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
project-migrate-v3-to-v4
branch
from
0ffa6aa to
643c760
Compare
ffromani
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cc @Tal-or |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have no good reason to get stuck on layout v3 and make our time harder when consuming upcoming changes and fixes.
Most of the changes here stem from the fact we change the path of the API package.
We also consume as much as possible from the new Makefile features.
Done using https://book.kubebuilder.io/migration/migration_guide_gov3_to_gov4