Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] deps: bump deployer dep #1103

Open
wants to merge 3 commits into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] deps: bump deployer dep #1103

wants to merge 3 commits into from
+105 −5

Conversation

ffromani
Copy link
Member

consume u/s fixes

@ffromani
[release-4.17] deps: bump deployer dep
c003977 
consume u/s fixes

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci openshift-ci bot requested review from shajmakh and Tal-or December 10, 2024 08:53
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Member Author

/hold

for @Tal-or 's review

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 10, 2024
@ffromani
snyk: silence warning about cobra
9d5fe35 
cobra is an indirect dependency we pulled since long time ago,
but the linter started to emit warnings about it only recently.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani
Copy link
Member Author

@Tal-or lanes are failing with the exact error this PR should solve. But this IIRC should be caused by the very old bug/misconfiguration which causes the lane run with images built against EXISTING codebase (not the patched codebase changed by the PR under test), right?

@Tal-or
Copy link
Collaborator

Tal-or commented Dec 11, 2024

I see a different issue here:

[2024-12-10T11:44:53.981Z] ClusterServiceVersion numaresources-operator.v4.17.999-snapshot was created but never became ready
[2024-12-10T11:44:53.983Z] Dumping ClusterServiceVersion numaresources-operator.v4.17.999-snapshot as /logs/artifacts/csv-numaresources-operator.v4.17.999-snapshot.yaml
[2024-12-10T11:44:54.682Z] ClusterServiceVersion numaresources-operator.v4.17.999-snapshot status phase: Failed
[2024-12-10T11:44:55.008Z] ClusterServiceVersion numaresources-operator.v4.17.999-snapshot status message: install failed: deployment numaresources-controller-manager not ready before timeout: deployment "numaresources-controller-manager" exceeded its progress deadline
[2024-12-10T11:44:55.337Z] ClusterServiceVersion numaresources-operator.v4.17.999-snapshot status reason: InstallCheckFailed
[2024-12-10T11:44:55.338Z] Dumping all installPlans in namespace numaresources-operator as /logs/artifacts/installPlans.yaml
[2024-12-10T11:44:55.661Z] Script Completed Execution With Failures !

@Tal-or
Copy link
Collaborator

Tal-or commented Dec 11, 2024

/retest

@ffromani
Copy link
Member Author

let's investigate the failures

@ffromani ffromani mentioned this pull request Dec 11, 2024
Merged
@Tal-or @ffromani
rbac: add Get permission for config.openshift.io.infrastructures
dcb9ca5 
Consuming the lates updates from the deploy
allow us now to distinguish between OCP and HCP flavors.

But for that an access to the config.openshift.io.infrastructures object
is needed.
Adding the necessary rbac.

4.17 backport notice: regenerated manifests

Signed-off-by: Talor Itzhak <[email protected]>
(cherry picked from commit 0adba16)
@Tal-or
Copy link
Collaborator

Tal-or commented Dec 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@ffromani
Copy link
Member Author

let's investigate the failures

we figured out offline

I1211 11:46:55.485110       1 main.go:186] "starting" program="numaresources-operator" version="v0.4.17-rc1.dev11+g6a5ac3f1" gitcommit="6a5ac3f1" golang="go1.22.1" vl=4 auxv="4"
I1211 11:46:55.498801       1 discover.go:34] "platform detection" kind="Unknown" reason="autodetection failed"
E1211 11:46:55.498823       1 discover.go:37] "cannot autodetect the platform, and no platform given" err="infrastructures.config.openshift.io \"cluster\" is forbidden: User \"system:serviceaccount:openshift-numaresources:numaresources-controller-manager\" cannot get resource \"infrastructures\" in API group \"config.openshift.io\" at the cluster scope"

found in gather_extra

@ffromani
Copy link
Member Author

ok, now it seems RTEs can't go running, so let's check

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e dcb9ca5 link true /test ci-e2e
ci/prow/ci-install-e2e dcb9ca5 link true /test ci-install-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Tal-or
Copy link
Collaborator

Tal-or commented Dec 12, 2024 •
edited
Loading

looks like DaemonSet are not created for some reason:

[Install] durability with a running cluster with all the components and overall deployment [test_id:47587][tier1] should restart RTE DaemonSet when image is updated in NUMAResourcesOperator
/go/src/github.com/openshift-kni/numaresources-operator/test/e2e/install/install_test.go:189
  STEP: creating the KC object: kc-test @ 12/11/24 17:36:42.901
  STEP: creating the NRO object: numaresourcesoperator @ 12/11/24 17:36:42.921
  STEP: waiting for MCP to get updated @ 12/11/24 17:36:43.029
  STEP: getting up-to-date NRO object @ 12/11/24 17:47:43.595
W1211 17:47:43.608861   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:47:53.610008   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:48:03.609600   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0

W1211 17:48:23.610105   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:48:33.609734   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:48:43.612359   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:48:53.610309   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:49:03.609313   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:49:13.609782   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:49:23.612038   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:49:33.609978   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:49:43.609857   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:49:53.609812   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:50:03.611773   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:50:13.609676   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:50:23.609822   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:50:33.612688   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:50:43.611921   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:50:53.609679   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:51:03.609620   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:51:23.609978   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:51:33.609800   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:51:43.611615   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:51:53.609660   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:52:03.609366   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:52:13.609636   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
W1211 17:52:33.610254   32664 install_test.go:203] unsupported daemonsets (/MCP) count: 0
I1211 17:52:43.658431   32664 install_test.go:392] NRO not available (1 DaemonSet)
I1211 17:52:43.658453   32664 install_test.go:395] daemonset numaresources-operator/numaresourcesoperator-worker desired 3 scheduled 3 ready 0
W1211 17:52:43.719966   32664 install_test.go:416] DaemonSet numaresources-operator/numaresourcesoperator-worker -> Pod numaresources-operator/numaresourcesoperator-worker-7kbds -> error getting logs: the server rejected our request for an unknown reason (get pods numaresourcesoperator-worker-7kbds)
W1211 17:52:43.747980   32664 install_test.go:416] DaemonSet numaresources-operator/numaresourcesoperator-worker -> Pod numaresources-operator/numaresourcesoperator-worker-pcpb7 -> error getting logs: the server rejected our request for an unknown reason (get pods numaresourcesoperator-worker-pcpb7)
W1211 17:52:43.776832   32664 install_test.go:416] DaemonSet numaresources-operator/numaresourcesoperator-worker -> Pod numaresources-operator/numaresourcesoperator-worker-qbwnm -> error getting logs: the server rejected our request for an unknown reason (get pods numaresourcesoperator-worker-qbwnm)
  [FAILED] in [It] - /go/src/github.com/openshift-kni/numaresources-operator/test/e2e/install/install_test.go:211 @ 12/11/24 17:52:43.777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajmakh shajmakh Awaiting requested review from shajmakh

@Tal-or Tal-or Awaiting requested review from Tal-or

Assignees

@Tal-or Tal-or

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffromani @Tal-or